Revamp messaging when copying files #2492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Once again show one file per line * Make it possible to nicely label special roots (i.e. the pkgdown package)
jayhesselberth
approved these changes
Apr 23, 2024
Bisaloo
reviewed
Apr 24, 2024
| copy_asset_dir( | ||
| pkg, | ||
| path_package_pkgdown("assets", template$package, pkg$bs_version), | ||
| src_root = system_file(package = template_package), |
There was a problem hiding this comment.
Since this was merged, we get:
Error:
! in callr subprocess.
Caused by error in `copy_assets(pkg)`:
! object 'template_package' not found
Any chance this was meant to be?
src_root = system_file(package = template$package),I can open a new issue if you prefer.
There was a problem hiding this comment.
Oops yes. Let me push a fix real quick
SebKrantz
pushed a commit
to SebKrantz/pkgdown
that referenced
this pull request
Jun 1, 2024
* Once again show one file per line * Make it possible to nicely label special roots (i.e. the pkgdown package)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jayhesselberth I can't remember if we discussed this at the time, but
cli::cli_inform()always collapses to a single string, so I think the easiest way to get one line per file is to usewalk2().Fixes #2445