Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add redirects for topic aliases #2501

Merged
merged 3 commits into from
May 2, 2024
Merged

Automatically add redirects for topic aliases #2501

merged 3 commits into from
May 2, 2024

Conversation

hadley
Copy link
Member

@hadley hadley commented Apr 25, 2024

Fixes #1876

@DavisVaughan @lionel- would one of you mind double checking that this creates the right aliases for one of vctrs/tidyr/dplyr/etc?

@lionel-
Copy link
Member

lionel- commented Apr 30, 2024

@hadley If I build the rlang site locally, then try e.g. dev/reference/tidy-dots.html (should be aliased to dyn-dots.html), I'm seeing a 404 error. Am I missing anything?

@hadley
Copy link
Member Author

hadley commented Apr 30, 2024

@lionel- hmmm, that works for me. Did you see the lines like:

Adding redirect from reference/syms.html to reference/sym.html.
Adding redirect from reference/tidy-dots.html to reference/dyn-dots.html.
Adding redirect from reference/tidyeval-data.html to reference/dot-data.html.

Also note that due because of the way pkgdown sites are designed, the redirect will always go to the live site.

@lionel-
Copy link
Member

lionel- commented May 2, 2024

It works!

@hadley hadley merged commit a8e849c into main May 2, 2024
12 checks passed
@hadley hadley deleted the alias-redirects branch May 2, 2024 19:12
SebKrantz pushed a commit to SebKrantz/pkgdown that referenced this pull request Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate redirects for aliases
2 participants