-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite navbar generation code from first principles #2547
Conversation
github: | ||
icon: fab fa-github fa-lg | ||
href: https://github.com/r-lib/pkgdown | ||
aria-label: github | ||
aria-label: GitHub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our label was a bit lazy before
This looks good but the position of the search box is slightly different on the new site — is there a CSS rule that also needs updating? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
- should there be tests for the two other new errors?
- is it worth re-running an HTML validator?
- should there a "gallery" of some YAML configurations for the navbar in the tests?
|
@maelle I got tired of having a bunch of code copied from rmarkdown and then modified over the years. It was hard to understand the logic and challenging to make changes. So I've rewritten it from scratch. Along the way:
target
field for linksdepth
to mean two different things (menu and path), causing search to fail pages deeper in the site<ul>
and<li>
instead of bare<div>
s