Improve check_opengraph() #2552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hadley
commented
May 16, 2024
hadley
commented
- Show path to make it easier to see where the problem is coming from
- Use our standard display of yaml variables
- Other various minor tidyups
jayhesselberth
approved these changes
May 17, 2024
There was a problem hiding this comment.
Looks good to me. @gadenbuie originally added open graph support and may want to weigh in.
hadley
commented
May 17, 2024
|
Thanks for tagging me @jayhesselberth, I took a quick look and nothing jumped out at me. Looks great! Showing the path where the error happens will be very helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.