Rethrow yaml parsing error (add a clickable link to _pkgdown.yml) #2559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…word pkgdown will show in real life situation.
Closed
…e testing different `_pkgdown.yml` error messages.
olivroy
changed the title
hadley
reviewed
May 20, 2024
hadley
reviewed
May 20, 2024
…ess path from original error message.
olivroy
commented
May 21, 2024
hadley
reviewed
May 21, 2024
hadley
reviewed
May 21, 2024
hadley
reviewed
May 21, 2024
| @@ -82,3 +82,16 @@ test_that("titles don't get autolinked code", { | |||
| rd <- rd_text("\\title{\\code{foo()}}", fragment = FALSE) | |||
| expect_equal(extract_title(rd), "<code>foo()</code>") | |||
| }) | |||
|
|
|||
| test_that("read_meta() errors gracefully if _pkgdown.yml failed to parse", { | |||
| pkg <- local_pkgdown_site() | |||
There was a problem hiding this comment.
This isn't quite right yet, but we're moving towards more inline tests, where possible.
There was a problem hiding this comment.
Oh, I see! Let me know if you want me to do further adjustments
SebKrantz
pushed a commit
to SebKrantz/pkgdown
that referenced
this pull request
Jun 1, 2024
…lib#2559) Co-authored-by: Hadley Wickham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may be better not to try to do too much?
Maybe this is sufficient?
See #2558 for rationale.