Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test quarto vignette rendering #2572

Closed
wants to merge 2 commits into from
Closed

Test quarto vignette rendering #2572

wants to merge 2 commits into from

Conversation

jayhesselberth
Copy link
Collaborator

Closes #2210

Copy link

github-actions bot commented May 21, 2024

@jayhesselberth jayhesselberth requested a review from hadley May 21, 2024 23:36
@jayhesselberth
Copy link
Collaborator Author

jayhesselberth commented May 21, 2024

Would authors need to include quarto in Suggests for this to work in other packages?

@jayhesselberth
Copy link
Collaborator Author

Hmm, this might be more complicated than I anticipated, the figure links don't work.

@hadley
Copy link
Member

hadley commented May 22, 2024

Yeah, I was going to tackle this soon. Currently pkgdown has a hack to just handle .qmd via rmarkdown, which works for basic vignettes but obviously fails with any quarto specific features. I think getting this to work is a decent amount of work, because we'll need to replicate the template munging code that we currently use for rmarkdown.

@jayhesselberth
Copy link
Collaborator Author

That's what I figured. Feel free to close and start fresh.

@hadley hadley closed this May 22, 2024
@jayhesselberth jayhesselberth deleted the quarto-vignette branch June 20, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quarto articles?
2 participants