Update navbar styling to use data-bs-theme attribute #2573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
commented
May 22, 2024
| @include border-radius($border-radius); | ||
| padding: 0.5rem; |
There was a problem hiding this comment.
As far as I can tell, this padding had no effect.
hadley
commented
May 22, 2024
| background: change-color($primary, $alpha: 0.1); | ||
| } | ||
|
|
||
| .navbar-dark { |
There was a problem hiding this comment.
I'm not sure why we had this; it doesn't seem necessary now.
hadley
commented
May 22, 2024
| @@ -1,5 +1,5 @@ | |||
| {{#navbar}} | |||
| <nav class="navbar fixed-top navbar-{{{type}}} navbar-expand-lg bg-{{{bg}}}" data-bs-theme="{{{type}}}" aria-label="{{#translate}}{{site_nav}}{{/translate}}"> | |||
There was a problem hiding this comment.
In preparation for #2338 — if you activate dark mode, we won't write these so that everything is controlled via css.
|
I think this makes sense. Changes to navbar colors are imperceptible. |
jayhesselberth
approved these changes
May 22, 2024
hadley
added a commit
that referenced
this pull request
May 22, 2024
SebKrantz
pushed a commit
to SebKrantz/pkgdown
that referenced
this pull request
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jayhesselberth does this make sense to you? It slightly changes the colour (hopefully not too noticeably), but computes them in such a way that switching to dark mode should be easier.