Unify config error messages #2610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To always show path at the beginning
maelle
reviewed
May 31, 2024
| @@ -43,7 +43,7 @@ build_article <- function(name, | |||
|
|
|||
| front <- rmarkdown::yaml_front_matter(input_path) | |||
| # Take opengraph from article's yaml front matter | |||
| front_opengraph <- check_open_graph(front$opengraph, input) | |||
| front_opengraph <- check_open_graph(pkg, front$opengraph, input) | |||
There was a problem hiding this comment.
how many of pkgdown functions now need pkg as argument 😂
jayhesselberth
approved these changes
May 31, 2024
SebKrantz
pushed a commit
to SebKrantz/pkgdown
that referenced
this pull request
Jun 1, 2024
To always show path at the beginning, eliminating `config_path()` helper since it's no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To always show path at the beginning
@jayhesselberth @maelle what do you think of this style? I like it because it allows us to reuse more code when producing errors for Rmd metadata. If you like the basic idea, I'll spend a bit more time polishing the code before merging the PR. It'll also make it easier to integrate #2549, so that whenever the error occurs in a GHA, you'll get an annotation on the file that caused the problem.