Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve round trip error message #1867

Merged
merged 4 commits into from
Sep 27, 2023
Merged

Improve round trip error message #1867

merged 4 commits into from
Sep 27, 2023

Conversation

hadley
Copy link
Member

@hadley hadley commented Sep 22, 2023

Fixes #1771

@hadley hadley requested a review from DavisVaughan September 22, 2023 17:00
@hadley
Copy link
Member Author

hadley commented Sep 22, 2023

After review and prior to merge, should move check_roundtrip() to better location. Might be better to create new snapshot-value.R file?

DavisVaughan
DavisVaughan approved these changes Sep 27, 2023
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
@hadley hadley merged commit bf6b939 into main Sep 27, 2023
12 checks passed
@hadley hadley deleted the better-roundtrip-error branch September 27, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavisVaughan DavisVaughan DavisVaughan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

expect_snapshot_value() fails when one attribute contains a function
2 participants
@hadley @DavisVaughan