Better algorithm for determining file extension #1961
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusted snapshot_meta helper function to adjust check for presence of file extension in `files` argument. Fixes issue where periods in file name are mistaken for signifying file extension (r-lib#1579).
|
Unfortunately if you look at the failing tests, you can see that assumption is not true 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted snapshot_meta helper function to adjust check for presence of file extension in
filesargument. Fixes issue where periods in file name are mistaken for file extension. Fixes #1579.Implicitly assumes snapshot file extension will be
.mdor nothing, but based on review of the function I think this is valid.