Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pkg-config on Windows when available. #85

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

kalibera
Copy link
Contributor

This will use pkg-config to establish the libraries to link when pkg-config is available (which will soon be in Rtools). This should reduce the frequency of needed updates to linking when new features are linked/enabled in geos or proj or in libraries they use.

@edzer edzer merged commit e7467e5 into r-spatial:master Feb 9, 2024
4 of 5 checks passed
@edzer
Copy link
Member

edzer commented Feb 9, 2024

Thanks!

@edzer
Copy link
Member

edzer commented Feb 9, 2024

This now gives, on win-builder a WARNING, in 00install.log:

** applying installation-time patches
checking file src/Makevars.ucrt
Hunk #1 FAILED at 73.
1 out of 1 hunk FAILED
WARNING: failed to apply patch d:/RCompile/CRANpkg/r_packages/patches/CRAN/lwgeom.diff

shall I proceed submitting this to CRAN nevertheless?

@kalibera
Copy link
Contributor Author

kalibera commented Feb 9, 2024

This now gives, on win-builder a WARNING, in 00install.log:

** applying installation-time patches
checking file src/Makevars.ucrt
Hunk #1 FAILED at 73.
1 out of 1 hunk FAILED
WARNING: failed to apply patch d:/RCompile/CRANpkg/r_packages/patches/CRAN/lwgeom.diff

shall I proceed submitting this to CRAN nevertheless?

I think you can submit. If it gets rejected, you can follow up on [email protected]. Or you can ask there right away if you prefer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants