Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support specify contract path input with or without -p flag #350

Open
AlexD10S opened this issue Nov 25, 2024 · 2 comments
Open

chore: support specify contract path input with or without -p flag #350

AlexD10S opened this issue Nov 25, 2024 · 2 comments
Labels
DevEx Change to improve the Developer Experience good first issue Good for newcomers

Comments

@AlexD10S
Copy link
Collaborator

Currently, contract commands use the -p flag to specify the path to a contract or artifact file. The experience can be improved if pop-cli supports both options: using the -p flag and specifying the path directly without it (subcommand).

Example:

pop call contract -p ../contract.json 

can simply be

pop call contract ../contract.json

This improvement should be consistent across all contract-related commands, including:

  • pop build
  • pop up contract
  • pop call contract
@AlexD10S AlexD10S added good first issue Good for newcomers DevEx Change to improve the Developer Experience labels Nov 25, 2024
@AlexD10S AlexD10S changed the title refactor: support specify contract path input with or without -p flag chore: support specify contract path input with or without -p flag Nov 25, 2024
@ndkazu
Copy link

ndkazu commented Dec 3, 2024

Hello, I started working on this issue in PR #361 and confirmed that the improvement is working as expected for pop build.
pop call contract & some additional tests are still needed: Work in progress.

@ndkazu
Copy link

ndkazu commented Dec 11, 2024

@AlexD10S , I made a cleaner version of my first suggestion (modifications are minimal, and limited to pop build ...). I am still looking for other (less invasive?) routes, but have a look at my additional comments in the PR, and let me know if it makes sense to propagate this method to pop up contract & pop call contract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevEx Change to improve the Developer Experience good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants