Support specify contract path input with or without -p flag

[ndkazu]

Description

This PR is addressing issue #350.
Allow pop-cli to supports two ways to to specify the path to a contract or artifact file: using the -p flag or specifying the path directly without it:

pop call contract -p ../contract.json 

and

pop call contract ../contract.json

should both be possible.

Implementation

Two arguments are used to specify the path: One Optional, and one positional:

#[arg(long,required = false)]
	pub(crate) path: Option<PathBuf>,
	#[arg(value_name = "PATH",required = false)]
	pub(crate) path1: Option<PathBuf>,

The following contract-related commands will be upgraded

• pop build
• pop up contract
• pop call contract

[AlexD10S]

Thanks for your interest in contributing to pop-cli!
I’ve reviewed your approach, and maintaining a second argument path1 might not be the cleanest way to solve this.
You might want to explore using positional arguments, as discussed here clap-rs/clap#2260, or consider the use of subcommands (https://docs.rs/clap/latest/clap/trait.Subcommand.html) instead.

[ndkazu]

Thanks for your interest in contributing to pop-cli! I’ve reviewed your approach, and maintaining a second argument path1 might not be the cleanest way to solve this. You might want to explore using positional arguments, as discussed here clap-rs/clap#2260, or consider the use of subcommands (https://docs.rs/clap/latest/clap/trait.Subcommand.html) instead.

Hello, I looked into it, and it seems to me that what we're trying to do is closer to this, and this.
and from what I understood from these discussions involving the Clap devTeam, it seems like using two arguments is the way to go(maybe not the way I did it though... maybe use required_unless = ... instead of required = ... ). An experimental module exists here, but I don't think the CLAP team is wiling to consider it.

[ndkazu]

@AlexD10S , I made a cleaner version of my first suggestion (modifications are minimal, and limited to pop build ...). I am still looking for other (less invasive?) routes, but based on my previous comment, let me know if it makes sense to propagate this method to pop up contract & pop call contract.

[AlexD10S]

@AlexD10S , I made a cleaner version of my first suggestion (modifications are minimal, and limited to pop build ...). I am still looking for other (less invasive?) routes, but based on my previous comment, let me know if it makes sense to propagate this method to pop up contract & pop call contract.

Thanks! Running the CI to check all tests pass, and I'll do a proper review

[ndkazu]

@AlexD10S , I made a cleaner version of my first suggestion (modifications are minimal, and limited to pop build ...). I am still looking for other (less invasive?) routes, but based on my previous comment, let me know if it makes sense to propagate this method to pop up contract & pop call contract.

Thanks! Running the CI to check all tests pass, and I'll do a proper review

I saw that the CLI was failing, and did a cargo +nightly fmt as a tentative to fix the error.