-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new parachain template and remove outdated one from parity #297
Open
AlexD10S
wants to merge
21
commits into
main
Choose a base branch
from
alex/parity-template
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
12610ef
feat: include new parachain template and remove old one for Parity
AlexD10S 31ac60d
fix: tests
AlexD10S fec60a8
fix: order in test
AlexD10S 392bdd9
fix: export PATH
AlexD10S c085a66
chore: merge main
AlexD10S ba6b7e0
Merge branch 'main' into alex/parity-template
AlexD10S e5ab436
chore: bump zombienet-sdk version
AlexD10S 5da07ef
fix: remove parity evm
AlexD10S 6070af6
fix: missing changes
AlexD10S dbf1ee7
fix: parse collator and parachain-template-node without path for spawn
AlexD10S d83700d
chore: remove set PATH
AlexD10S 316de33
refactor: functionality and test
AlexD10S 9f2076b
refactor: prefix for external templates
AlexD10S 7addd9b
fix: deprecate old command for generating parity contracts template
AlexD10S d40ec06
test: update configure_works test to test new functionality
AlexD10S 7017d63
test: fix unit tests templates
AlexD10S 9871fe2
fix: show deprecation message and fixes
AlexD10S 2b549c4
chore: merge main
AlexD10S 7fbb66b
docs: improve comments
AlexD10S abfca64
refactor: nitpicks in parachain description
AlexD10S 34ff183
fix: logic for substrate-contracts-node without path in config file
AlexD10S File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would keep it
pop build
. Adding--release
takes way too long for development, and could degrade the UX for parachain development.--release
should be suggested when prepping the chain for onboarding.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made this change because it's common in the Zombienet configuration file to reference
/target/release/
. See https://github.com/OpenZeppelin/polkadot-runtime-templates/blob/main/generic-template/zombienet-config/devnet.toml#L21 or https://github.com/r0gue-io/pop-cli/blob/main/tests/networks/template.toml#L16.Without running
pop build --release
, the path needs to be manually updated in the Zombienet file for things to work correctly.