Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: include call contract improvements in the existing docs #11

Merged
merged 4 commits into from
Dec 12, 2024
Merged

docs: include call contract improvements in the existing docs #11

merged 4 commits into from
Dec 12, 2024

Conversation

AlexD10S
Copy link
Collaborator

@AlexD10S AlexD10S commented Dec 10, 2024 •
edited
Loading

Documentation for pop call contract

[sc-1777]

@AlexD10S AlexD10S marked this pull request as draft December 10, 2024 15:32
@AlexD10S AlexD10S marked this pull request as ready for review December 10, 2024 19:03
al3mart
al3mart approved these changes Dec 10, 2024
View reviewed changes
Copy link

@al3mart al3mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Daanvdplas
Daanvdplas requested changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@Daanvdplas Daanvdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nitpicks and I feel the gif can be improved a little bit (sorry)

pop-cli-for-smart-contracts/guides/calling-your-contract.md Show resolved Hide resolved
pop-cli-for-smart-contracts/guides/calling-your-contract.md Outdated Show resolved Hide resolved
pop-cli-for-smart-contracts/guides/calling-your-contract.md Show resolved Hide resolved
pop-cli-for-smart-contracts/guides/calling-your-contract.md Show resolved Hide resolved
pop-cli-for-smart-contracts/guides/calling-your-contract.md Show resolved Hide resolved
pop-cli-for-smart-contracts/guides/calling-your-contract.md Outdated Show resolved Hide resolved
pop-cli-for-smart-contracts/guides/calling-your-contract.md Show resolved Hide resolved
pop-cli-for-smart-contracts/pop-cli/call.md Outdated Show resolved Hide resolved
pop-cli-for-smart-contracts/pop-cli/call.md Outdated Show resolved Hide resolved
@AlexD10S AlexD10S requested a review from Daanvdplas December 12, 2024 15:49
Daanvdplas
Daanvdplas approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@Daanvdplas Daanvdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good lets get this merged and refactor the docs in next sprint!

@AlexD10S AlexD10S merged commit 17a20fa into main Dec 12, 2024
4 of 5 checks passed
@AlexD10S AlexD10S deleted the feat/call_contract branch December 12, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daanvdplas Daanvdplas Daanvdplas approved these changes

@al3mart al3mart al3mart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexD10S @al3mart @Daanvdplas