Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: include call chain new feature #12

Merged
merged 8 commits into from
Dec 12, 2024
Merged

docs: include call chain new feature #12

merged 8 commits into from
Dec 12, 2024

Conversation

AlexD10S
Copy link
Collaborator

@AlexD10S AlexD10S commented Dec 10, 2024 •
edited
Loading

Documentation for pop call chain

[sc-1777]

@AlexD10S AlexD10S marked this pull request as ready for review December 10, 2024 19:02
@AlexD10S AlexD10S changed the title docs: include call parachain new feature docs: include call chain new feature Dec 10, 2024
al3mart
al3mart reviewed Dec 10, 2024
View reviewed changes
Copy link

@al3mart al3mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Left a some comments, but overall it explains nicely what the capabilities of pop call chain are.

pop-cli-for-appchains/guides/calling-a-chain.md Outdated Show resolved Hide resolved
pop-cli-for-appchains/guides/calling-a-chain.md Outdated Show resolved Hide resolved
pop-cli-for-appchains/pop-cli/call.md Outdated Show resolved Hide resolved
@AlexD10S AlexD10S requested a review from al3mart December 10, 2024 21:36
al3mart
al3mart requested changes Dec 11, 2024
View reviewed changes
pop-cli-for-appchains/guides/calling-a-chain.md Outdated Show resolved Hide resolved
pop-cli-for-appchains/pop-cli/call.md Outdated Show resolved Hide resolved
al3mart
al3mart approved these changes Dec 11, 2024
View reviewed changes
Copy link

@al3mart al3mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback addressed and looking good!

@Daanvdplas Daanvdplas self-requested a review December 12, 2024 10:13
Daanvdplas
Daanvdplas requested changes Dec 12, 2024
View reviewed changes
pop-cli-for-appchains/guides/calling-a-chain.md Outdated Show resolved Hide resolved
pop-cli-for-appchains/guides/calling-a-chain.md Outdated Show resolved Hide resolved
pop-cli-for-appchains/guides/calling-a-chain.md Outdated Show resolved Hide resolved
pop-cli-for-appchains/guides/calling-a-chain.md Outdated Show resolved Hide resolved
pop-cli-for-appchains/guides/calling-a-chain.md Outdated Show resolved Hide resolved
pop-cli-for-appchains/pop-cli/call.md Show resolved Hide resolved
@AlexD10S AlexD10S requested a review from Daanvdplas December 12, 2024 15:33
Daanvdplas
Daanvdplas approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@Daanvdplas Daanvdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright lets get this merged and refactor the docs in next sprint!

@AlexD10S AlexD10S merged commit fc2bf69 into main Dec 12, 2024
5 checks passed
@AlexD10S AlexD10S deleted the feat/call_chain branch December 12, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daanvdplas Daanvdplas Daanvdplas approved these changes

@al3mart al3mart al3mart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexD10S @al3mart @Daanvdplas