Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: assert last event #25

Merged
merged 5 commits into from
Nov 5, 2024

fix: formatting

4b6fe8c
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

feat: assert last event #25

fix: formatting
4b6fe8c
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Nov 4, 2024 in 2s

clippy

143 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 143
Note 0
Help 0

Versions

  • rustc 1.81.0 (eeb90cda1 2024-09-04)
  • cargo 1.81.0 (2dbb1af80 2024-08-20)
  • clippy 0.1.81 (eeb90cd 2024-09-04)

Annotations

Check warning on line 24 in crates/drink/drink-cli/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for the crate

warning: missing documentation for the crate
  --> crates/drink/drink-cli/src/main.rs:1:1
   |
1  | / use std::path::PathBuf;
2  | |
3  | | use anyhow::Result;
4  | | use clap::Parser;
...  |
23 | |     run_ui(args.path)
24 | | }
   | |_^
   |
   = note: requested on the command line with `-W missing-docs`

Check warning on line 121 in crates/drink/drink-cli/src/executor/contract.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `let...else` may be rewritten with the `?` operator

warning: this `let...else` may be rewritten with the `?` operator
   --> crates/drink/drink-cli/src/executor/contract.rs:115:2
    |
115 | /     let Some(file) = entries
116 | |         .into_iter()
117 | |         .filter_map(|e| e.ok())
118 | |         .find(|e| e.path().extension().unwrap_or_default() == "wasm")
119 | |     else {
120 | |         return None;
121 | |     };
    | |______^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
    = note: `#[warn(clippy::question_mark)]` on by default
help: replace it with
    |
115 ~     let file = entries
116 ~         .into_iter()
117 ~         .filter_map(|e| e.ok())
118 ~         .find(|e| e.path().extension().unwrap_or_default() == "wasm")?;
    |

Check warning on line 13 in crates/drink/drink-cli/src/app_state/contracts.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `transcoder` is never read

warning: field `transcoder` is never read
  --> crates/drink/drink-cli/src/app_state/contracts.rs:13:6
   |
9  | pub struct Contract {
   |            -------- field in this struct
...
13 |     pub transcoder: Arc<ContractMessageTranscoder>,
   |         ^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

Check warning on line 32 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a module

warning: missing documentation for a module
  --> crates/pop-drink/src/lib.rs:32:3
   |
32 |         pub mod v0 {
   |         ^^^^^^^^^^

Check warning on line 42 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a type alias

warning: missing documentation for a type alias
  --> crates/pop-drink/src/lib.rs:42:2
   |
42 |     pub type AccountId = AccountIdFor<Runtime>;
   |     ^^^^^^^^^^^^^^^^^^

Check warning on line 41 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a type alias

warning: missing documentation for a type alias
  --> crates/pop-drink/src/lib.rs:41:2
   |
41 |     pub type Balance = BalanceFor<Runtime>;
   |     ^^^^^^^^^^^^^^^^

Check warning on line 164 in crates/pop-drink/src/macros.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a function

warning: missing documentation for a function
   --> crates/pop-drink/src/macros.rs:158:1
    |
158 | / pub fn assert_last_contract_event_inner<S, E>(session: &Session<S>, event: E)
159 | | where
160 | |     S: Sandbox,
161 | |     S::Runtime: pallet_contracts::Config,
162 | |     <S::Runtime as frame_system::Config>::RuntimeEvent:
163 | |         TryInto<pallet_contracts::Event<S::Runtime>>,
164 | |     E: Decode + Encode + Debug,
    | |_______________________________^

Check warning on line 115 in crates/pop-drink/src/macros.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a function

warning: missing documentation for a function
   --> crates/pop-drink/src/macros.rs:112:1
    |
112 | / pub fn assert_err_inner<R, E, Error>(result: Result<R, E>, expected_error: Error)
113 | | where
114 | |     E: Into<u32>,
115 | |     Error: From<u32> + Into<u32> + Debug,
    | |_________________________________________^
    |
    = note: requested on the command line with `-W missing-docs`

Check warning on line 68 in crates/pop-drink/src/error.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless use of `vec!`

warning: useless use of `vec!`
  --> crates/pop-drink/src/error.rs:68:15
   |
68 |             let data = vec![vec![index], module_error.to_vec()].concat();
   |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[vec![index], module_error.to_vec()]`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
   = note: `#[warn(clippy::useless_vec)]` on by default

Check warning on line 179 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:179:5
    |
179 | ///     .as_slice()
    |     ^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 178 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:178:5
    |
178 | ///     .encode()
    |     ^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 177 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:177:5
    |
177 | ///     }
    |     ^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 176 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:176:5
    |
176 | ///         value: 42,
    |     ^^^^^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 175 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:175:5
    |
175 | ///     ContractEvent {
    |     ^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 174 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:174:5
    |
174 | ///     last_contract_event::<Pop>(&session).unwrap(),
    |     ^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 131 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:131:5
    |
131 | ///     )
    |     ^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 130 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:130:5
    |
130 | ///         init_value,
    |     ^^^^^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 129 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:129:5
    |
129 | ///         input,
    |     ^^^^^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 128 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:128:5
    |
128 | ///         "transfer",
    |     ^^^^^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 127 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:127:5
    |
127 | ///         session,
    |     ^^^^^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 126 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:126:5
    |
126 | ///     call::<Pop, (), ContractError>(
    |     ^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 125 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:125:5
    |
125 | ///     // `ContractError` is the error type used by the contract.
    |     ^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 124 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:124:5
    |
124 | ///     // `()` is the successful result type used by the contract.
    |     ^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 122 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:122:5
    |
122 | ///     // Call contract.
    |     ^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 120 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:120:5
    |
120 | ///     assert_ok!(deploy<Pop, ContractError>(&mut session, bundle, "new", input, salt, init_value));
    |     ^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments