Skip to content

feat: pop drink

feat: pop drink #52

GitHub Actions / clippy succeeded Oct 18, 2024 in 1s

clippy

137 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 137
Note 0
Help 0

Versions

  • rustc 1.81.0 (eeb90cda1 2024-09-04)
  • cargo 1.81.0 (2dbb1af80 2024-08-20)
  • clippy 0.1.81 (eeb90cd 2024-09-04)

Annotations

Check warning on line 24 in crates/drink/drink-cli/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for the crate

warning: missing documentation for the crate
  --> crates/drink/drink-cli/src/main.rs:1:1
   |
1  | / use std::path::PathBuf;
2  | |
3  | | use anyhow::Result;
4  | | use clap::Parser;
...  |
23 | |     run_ui(args.path)
24 | | }
   | |_^
   |
   = note: requested on the command line with `-W missing-docs`

Check warning on line 121 in crates/drink/drink-cli/src/executor/contract.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `let...else` may be rewritten with the `?` operator

warning: this `let...else` may be rewritten with the `?` operator
   --> crates/drink/drink-cli/src/executor/contract.rs:115:2
    |
115 | /     let Some(file) = entries
116 | |         .into_iter()
117 | |         .filter_map(|e| e.ok())
118 | |         .find(|e| e.path().extension().unwrap_or_default() == "wasm")
119 | |     else {
120 | |         return None;
121 | |     };
    | |______^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
    = note: `#[warn(clippy::question_mark)]` on by default
help: replace it with
    |
115 ~     let file = entries
116 ~         .into_iter()
117 ~         .filter_map(|e| e.ok())
118 ~         .find(|e| e.path().extension().unwrap_or_default() == "wasm")?;
    |

Check warning on line 13 in crates/drink/drink-cli/src/app_state/contracts.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `transcoder` is never read

warning: field `transcoder` is never read
  --> crates/drink/drink-cli/src/app_state/contracts.rs:13:6
   |
9  | pub struct Contract {
   |            -------- field in this struct
...
13 |     pub transcoder: Arc<ContractMessageTranscoder>,
   |         ^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

Check warning on line 30 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a module

warning: missing documentation for a module
  --> crates/pop-drink/src/lib.rs:30:3
   |
30 |         pub mod v0 {
   |         ^^^^^^^^^^

Check warning on line 40 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a type alias

warning: missing documentation for a type alias
  --> crates/pop-drink/src/lib.rs:40:2
   |
40 |     pub type AccountId = AccountIdFor<Runtime>;
   |     ^^^^^^^^^^^^^^^^^^

Check warning on line 39 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a type alias

warning: missing documentation for a type alias
  --> crates/pop-drink/src/lib.rs:39:2
   |
39 |     pub type Balance = BalanceFor<Runtime>;
   |     ^^^^^^^^^^^^^^^^
   |
   = note: requested on the command line with `-W missing-docs`

Check warning on line 68 in crates/pop-drink/src/error.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless use of `vec!`

warning: useless use of `vec!`
  --> crates/pop-drink/src/error.rs:68:15
   |
68 |             let data = vec![vec![index], module_error.to_vec()].concat();
   |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[vec![index], module_error.to_vec()]`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
   = note: `#[warn(clippy::useless_vec)]` on by default

Check warning on line 177 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:177:5
    |
177 | ///     .as_slice()
    |     ^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 176 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:176:5
    |
176 | ///     .encode()
    |     ^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 175 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:175:5
    |
175 | ///     }
    |     ^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 174 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:174:5
    |
174 | ///         value: 42,
    |     ^^^^^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 173 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:173:5
    |
173 | ///     ContractEvent {
    |     ^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 172 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:172:5
    |
172 | ///     last_contract_event::<Pop>(&session).unwrap(),
    |     ^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 129 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:129:5
    |
129 | ///     )
    |     ^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 128 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:128:5
    |
128 | ///         init_value,
    |     ^^^^^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 127 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:127:5
    |
127 | ///         input,
    |     ^^^^^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 126 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:126:5
    |
126 | ///         "transfer",
    |     ^^^^^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 125 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:125:5
    |
125 | ///         session,
    |     ^^^^^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 124 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:124:5
    |
124 | ///     call::<Pop, (), ContractError>(
    |     ^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 123 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:123:5
    |
123 | ///     // `ContractError` is the error type used by the contract.
    |     ^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 122 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:122:5
    |
122 | ///     // `()` is the successful result type used by the contract.
    |     ^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 121 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:121:5
    |
121 | ///     //
    |     ^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 120 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:120:5
    |
120 | ///     // Call contract.
    |     ^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 118 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:118:5
    |
118 | ///     assert_ok!(deploy<Pop, ContractError>(&mut session, bundle, "new", input, salt, init_value));
    |     ^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 117 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:117:5
    |
117 | ///     let bundle = BundleProvider::local().unwrap();
    |     ^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments