Skip to content

Merge pull request #26 from r0gue-io/chungquantin/feat-testnet #68

Merge pull request #26 from r0gue-io/chungquantin/feat-testnet

Merge pull request #26 from r0gue-io/chungquantin/feat-testnet #68

GitHub Actions / clippy succeeded Nov 7, 2024 in 1s

clippy

86 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 86
Note 0
Help 0

Versions

  • rustc 1.82.0 (f6e511eec 2024-10-15)
  • cargo 1.82.0 (8f40fc59f 2024-08-21)
  • clippy 0.1.82 (f6e511e 2024-10-15)

Annotations

Check warning on line 24 in crates/drink/drink-cli/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for the crate

warning: missing documentation for the crate
  --> crates/drink/drink-cli/src/main.rs:1:1
   |
1  | / use std::path::PathBuf;
2  | |
3  | | use anyhow::Result;
4  | | use clap::Parser;
...  |
23 | |     run_ui(args.path)
24 | | }
   | |_^
   |
   = note: requested on the command line with `-W missing-docs`

Check warning on line 121 in crates/drink/drink-cli/src/executor/contract.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `let...else` may be rewritten with the `?` operator

warning: this `let...else` may be rewritten with the `?` operator
   --> crates/drink/drink-cli/src/executor/contract.rs:115:2
    |
115 | /     let Some(file) = entries
116 | |         .into_iter()
117 | |         .filter_map(|e| e.ok())
118 | |         .find(|e| e.path().extension().unwrap_or_default() == "wasm")
119 | |     else {
120 | |         return None;
121 | |     };
    | |______^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
    = note: `#[warn(clippy::question_mark)]` on by default
help: replace it with
    |
115 ~     let file = entries
116 ~         .into_iter()
117 ~         .filter_map(|e| e.ok())
118 ~         .find(|e| e.path().extension().unwrap_or_default() == "wasm")?;
    |

Check warning on line 13 in crates/drink/drink-cli/src/app_state/contracts.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `transcoder` is never read

warning: field `transcoder` is never read
  --> crates/drink/drink-cli/src/app_state/contracts.rs:13:6
   |
9  | pub struct Contract {
   |            -------- field in this struct
...
13 |     pub transcoder: Arc<ContractMessageTranscoder>,
   |         ^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

Check warning on line 164 in crates/pop-drink/src/macros.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a function

warning: missing documentation for a function
   --> crates/pop-drink/src/macros.rs:158:1
    |
158 | / pub fn assert_last_contract_event_inner<S, E>(session: &Session<S>, event: E)
159 | | where
160 | |     S: Sandbox,
161 | |     S::Runtime: pallet_contracts::Config,
162 | |     <S::Runtime as frame_system::Config>::RuntimeEvent:
163 | |         TryInto<pallet_contracts::Event<S::Runtime>>,
164 | |     E: Decode + Encode + Debug,
    | |_______________________________^

Check warning on line 115 in crates/pop-drink/src/macros.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a function

warning: missing documentation for a function
   --> crates/pop-drink/src/macros.rs:112:1
    |
112 | / pub fn assert_err_inner<R, E, Error>(result: Result<R, E>, expected_error: Error)
113 | | where
114 | |     E: Into<u32>,
115 | |     Error: From<u32> + Into<u32> + Debug,
    | |_________________________________________^
    |
    = note: requested on the command line with `-W missing-docs`

Check warning on line 68 in crates/pop-drink/src/error.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless use of `vec!`

warning: useless use of `vec!`
  --> crates/pop-drink/src/error.rs:68:15
   |
68 |             let data = vec![vec![index], module_error.to_vec()].concat();
   |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[vec![index], module_error.to_vec()]`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
   = note: `#[warn(clippy::useless_vec)]` on by default

Check warning on line 211 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:211:8
    |
211 | ///        value: 42,
    |        ^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 165 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:165:8
    |
165 | ///        init_value,
    |        ^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 164 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:164:8
    |
164 | ///        input,
    |        ^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 163 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:163:8
    |
163 | ///        "transfer",
    |        ^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 162 in crates/pop-drink/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
   --> crates/pop-drink/src/lib.rs:162:8
    |
162 | ///        session,
    |        ^^^^ help: consider using four spaces per tab
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 65 in crates/pop-drink/src/macros.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
  --> crates/pop-drink/src/macros.rs:65:9
   |
65 | ///         }
   |         ^^^^ help: consider using four spaces per tab
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 64 in crates/pop-drink/src/macros.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
  --> crates/pop-drink/src/macros.rs:64:9
   |
64 | ///             _ => CustomError::StatusCode(value.0),
   |         ^^^^^^^^ help: consider using four spaces per tab
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 63 in crates/pop-drink/src/macros.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
  --> crates/pop-drink/src/macros.rs:63:9
   |
63 | ///             ...,
   |         ^^^^^^^^ help: consider using four spaces per tab
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments

Check warning on line 62 in crates/pop-drink/src/macros.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using tabs in doc comments is not recommended

warning: using tabs in doc comments is not recommended
  --> crates/pop-drink/src/macros.rs:62:9
   |
62 | ///         match value {
   |         ^^^^ help: consider using four spaces per tab
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#tabs_in_doc_comments
   = note: `#[warn(clippy::tabs_in_doc_comments)]` on by default

Check warning on line 183 in /home/runner/work/pop-drink/pop-drink/crates/ink-sandbox/src/macros.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for an associated function

warning: missing documentation for an associated function
  --> crates/drink/drink/src/lib.rs:30:2
   |
30 |     create_sandbox!(MinimalSandbox, (), crate::pallet_contracts_debugging::DrinkDebug);
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: this warning originates in the macro `frame_support::construct_runtime` which comes from the expansion of the macro `create_sandbox` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 177 in /home/runner/work/pop-drink/pop-drink/crates/ink-sandbox/src/macros.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a variant

warning: missing documentation for a variant
  --> crates/drink/drink/src/lib.rs:30:2
   |
30 |     create_sandbox!(MinimalSandbox, (), crate::pallet_contracts_debugging::DrinkDebug);
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: this warning originates in the macro `$crate::create_sandbox` which comes from the expansion of the macro `create_sandbox` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 178 in /home/runner/work/pop-drink/pop-drink/crates/ink-sandbox/src/macros.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a type alias

warning: missing documentation for a type alias
  --> crates/drink/drink/src/lib.rs:30:2
   |
30 |     create_sandbox!(MinimalSandbox, (), crate::pallet_contracts_debugging::DrinkDebug);
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: this warning originates in the macro `frame_support::construct_runtime` which comes from the expansion of the macro `create_sandbox` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 177 in /home/runner/work/pop-drink/pop-drink/crates/ink-sandbox/src/macros.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a type alias

warning: missing documentation for a type alias
  --> crates/drink/drink/src/lib.rs:30:2
   |
30 |     create_sandbox!(MinimalSandbox, (), crate::pallet_contracts_debugging::DrinkDebug);
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: this warning originates in the macro `frame_support::construct_runtime` which comes from the expansion of the macro `create_sandbox` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 176 in /home/runner/work/pop-drink/pop-drink/crates/ink-sandbox/src/macros.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a type alias

warning: missing documentation for a type alias
  --> crates/drink/drink/src/lib.rs:30:2
   |
30 |     create_sandbox!(MinimalSandbox, (), crate::pallet_contracts_debugging::DrinkDebug);
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: this warning originates in the macro `frame_support::construct_runtime` which comes from the expansion of the macro `create_sandbox` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 175 in /home/runner/work/pop-drink/pop-drink/crates/ink-sandbox/src/macros.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a type alias

warning: missing documentation for a type alias
  --> crates/drink/drink/src/lib.rs:30:2
   |
30 |     create_sandbox!(MinimalSandbox, (), crate::pallet_contracts_debugging::DrinkDebug);
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: this warning originates in the macro `frame_support::construct_runtime` which comes from the expansion of the macro `create_sandbox` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 174 in /home/runner/work/pop-drink/pop-drink/crates/ink-sandbox/src/macros.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a type alias

warning: missing documentation for a type alias
  --> crates/drink/drink/src/lib.rs:30:2
   |
30 |     create_sandbox!(MinimalSandbox, (), crate::pallet_contracts_debugging::DrinkDebug);
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: this warning originates in the macro `frame_support::construct_runtime` which comes from the expansion of the macro `create_sandbox` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 183 in /home/runner/work/pop-drink/pop-drink/crates/ink-sandbox/src/macros.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct field

warning: missing documentation for a struct field
  --> crates/drink/drink/src/lib.rs:30:2
   |
30 |     create_sandbox!(MinimalSandbox, (), crate::pallet_contracts_debugging::DrinkDebug);
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: this warning originates in the macro `frame_support::construct_runtime` which comes from the expansion of the macro `create_sandbox` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 178 in /home/runner/work/pop-drink/pop-drink/crates/ink-sandbox/src/macros.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a variant

warning: missing documentation for a variant
  --> crates/drink/drink/src/lib.rs:30:2
   |
30 |     create_sandbox!(MinimalSandbox, (), crate::pallet_contracts_debugging::DrinkDebug);
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: this warning originates in the macro `$crate::create_sandbox` which comes from the expansion of the macro `create_sandbox` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 176 in /home/runner/work/pop-drink/pop-drink/crates/ink-sandbox/src/macros.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a variant

warning: missing documentation for a variant
  --> crates/drink/drink/src/lib.rs:30:2
   |
30 |     create_sandbox!(MinimalSandbox, (), crate::pallet_contracts_debugging::DrinkDebug);
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: this warning originates in the macro `$crate::create_sandbox` which comes from the expansion of the macro `create_sandbox` (in Nightly builds, run with -Z macro-backtrace for more info)