Skip to content

feat: api fungibles pallet #158

feat: api fungibles pallet

feat: api fungibles pallet #158

Triggered via pull request July 23, 2024 14:54
@DaanvdplasDaanvdplas
synchronize #113
Status Success
Total duration 14s
Artifacts

lint-pr.yml

on: pull_request_target
Validate PR title for conventional commit compliance
4s
Validate PR title for conventional commit compliance
Fit to window
Zoom out
Zoom in

Annotations

16 warnings
large size difference between variants: node/src/cli.rs#L5
warning: large size difference between variants --> node/src/cli.rs:5:1 | 5 | / pub enum Subcommand { 6 | | /// Build a chain specification. 7 | | BuildSpec(sc_cli::BuildSpecCmd), ... | 19 | | ImportBlocks(sc_cli::ImportBlocksCmd), | | ------------------------------------- the second-largest variant contains at least 240 bytes ... | 39 | | Benchmark(frame_benchmarking_cli::BenchmarkCmd), | | ----------------------------------------------- the largest variant contains at least 512 bytes ... | 48 | | Key(sc_cli::KeySubcommand), 49 | | } | |_^ the entire enum is at least 512 bytes | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant = note: `#[warn(clippy::large_enum_variant)]` on by default help: consider boxing the large fields to reduce the total size of the enum | 39 | Benchmark(Box<frame_benchmarking_cli::BenchmarkCmd>), | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
use of deprecated struct `pallet_transaction_payment::CurrencyAdapter`: Please use the fungible trait and FungibleAdapter. This struct will be removed some time after March 2024.: runtime/testnet/src/lib.rs#L340
warning: use of deprecated struct `pallet_transaction_payment::CurrencyAdapter`: Please use the fungible trait and FungibleAdapter. This struct will be removed some time after March 2024. --> runtime/testnet/src/lib.rs:340:57 | 340 | type OnChargeTransaction = pallet_transaction_payment::CurrencyAdapter<Balances, ()>; | ^^^^^^^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default
bound is defined in more than one place: runtime/testnet/src/extensions.rs#L32
warning: bound is defined in more than one place --> runtime/testnet/src/extensions.rs:32:10 | 32 | fn call<E: Ext>(&mut self, env: Environment<E, InitState>) -> Result<RetVal, DispatchError> | ^ 33 | where 34 | E: Ext<T = T>, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations = note: `#[warn(clippy::multiple_bound_locations)]` on by default
use of deprecated struct `pallet_transaction_payment::CurrencyAdapter`: Please use the fungible trait and FungibleAdapter. This struct will be removed some time after March 2024.: runtime/devnet/src/lib.rs#L351
warning: use of deprecated struct `pallet_transaction_payment::CurrencyAdapter`: Please use the fungible trait and FungibleAdapter. This struct will be removed some time after March 2024. --> runtime/devnet/src/lib.rs:351:57 | 351 | type OnChargeTransaction = pallet_transaction_payment::CurrencyAdapter<Balances, ()>; | ^^^^^^^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default
bound is defined in more than one place: runtime/devnet/src/extensions/mod.rs#L45
warning: bound is defined in more than one place --> runtime/devnet/src/extensions/mod.rs:45:10 | 45 | fn call<E: Ext>(&mut self, env: Environment<E, InitState>) -> Result<RetVal, DispatchError> | ^ 46 | where 47 | E: Ext<T = T>, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations = note: `#[warn(clippy::multiple_bound_locations)]` on by default
used a field initializer for a tuple struct: scripts/fund-dev-accounts/./main.rs#L54
warning: used a field initializer for a tuple struct --> scripts/fund-dev-accounts/./main.rs:54:9 | 54 | id: AssetId { 0: Location { parents: 0, interior: Junctions::Here } }, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `AssetId(Location { parents: 0, interior: Junctions::Here })` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#init_numbered_fields
used a field initializer for a tuple struct: scripts/fund-dev-accounts/./main.rs#L52
warning: used a field initializer for a tuple struct --> scripts/fund-dev-accounts/./main.rs:52:36 | 52 | let assets = VersionedAssets::V4(Assets { | __________________________________________^ 53 | | 0: vec![Asset { 54 | | id: AssetId { 0: Location { parents: 0, interior: Junctions::Here } }, 55 | | fun: amount, 56 | | }], 57 | | }); | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#init_numbered_fields = note: `#[warn(clippy::init_numbered_fields)]` on by default help: try | 52 ~ let assets = VersionedAssets::V4(Assets(<[_]>::into_vec( 53 + // This rustc_box is not required, but it produces a dramatic improvement in compile 54 + // time when constructing arrays with many elements. 55 + #[rustc_box] 56 + $crate::boxed::Box::new([$($x),+]) 57 ~ ))); |
useless conversion to the same type: `<T as pallet_assets::Config<<T as fungibles::pallet::Config>::AssetsInstance>>::AssetId`: pallets/api/src/fungibles/benchmarking.rs#L39
warning: useless conversion to the same type: `<T as pallet_assets::Config<<T as fungibles::pallet::Config>::AssetsInstance>>::AssetId` --> pallets/api/src/fungibles/benchmarking.rs:39:4 | 39 | asset.clone().into(), | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `asset.clone()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default
used a field initializer for a tuple struct: scripts/fund-dev-accounts/./main.rs#L54
warning: used a field initializer for a tuple struct --> scripts/fund-dev-accounts/./main.rs:54:9 | 54 | id: AssetId { 0: Location { parents: 0, interior: Junctions::Here } }, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `AssetId(Location { parents: 0, interior: Junctions::Here })` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#init_numbered_fields
used a field initializer for a tuple struct: scripts/fund-dev-accounts/./main.rs#L52
warning: used a field initializer for a tuple struct --> scripts/fund-dev-accounts/./main.rs:52:36 | 52 | let assets = VersionedAssets::V4(Assets { | __________________________________________^ 53 | | 0: vec![Asset { 54 | | id: AssetId { 0: Location { parents: 0, interior: Junctions::Here } }, 55 | | fun: amount, 56 | | }], 57 | | }); | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#init_numbered_fields = note: `#[warn(clippy::init_numbered_fields)]` on by default help: try | 52 ~ let assets = VersionedAssets::V4(Assets(<[_]>::into_vec( 53 + // This rustc_box is not required, but it produces a dramatic improvement in compile 54 + // time when constructing arrays with many elements. 55 + #[rustc_box] 56 + $crate::boxed::Box::new([$($x),+]) 57 ~ ))); |
large size difference between variants: node/src/cli.rs#L5
warning: large size difference between variants --> node/src/cli.rs:5:1 | 5 | / pub enum Subcommand { 6 | | /// Build a chain specification. 7 | | BuildSpec(sc_cli::BuildSpecCmd), ... | 19 | | ImportBlocks(sc_cli::ImportBlocksCmd), | | ------------------------------------- the second-largest variant contains at least 240 bytes ... | 39 | | Benchmark(frame_benchmarking_cli::BenchmarkCmd), | | ----------------------------------------------- the largest variant contains at least 512 bytes ... | 48 | | Key(sc_cli::KeySubcommand), 49 | | } | |_^ the entire enum is at least 512 bytes | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant = note: `#[warn(clippy::large_enum_variant)]` on by default help: consider boxing the large fields to reduce the total size of the enum | 39 | Benchmark(Box<frame_benchmarking_cli::BenchmarkCmd>), | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
use of deprecated struct `pallet_transaction_payment::CurrencyAdapter`: Please use the fungible trait and FungibleAdapter. This struct will be removed some time after March 2024.: runtime/testnet/src/lib.rs#L340
warning: use of deprecated struct `pallet_transaction_payment::CurrencyAdapter`: Please use the fungible trait and FungibleAdapter. This struct will be removed some time after March 2024. --> runtime/testnet/src/lib.rs:340:57 | 340 | type OnChargeTransaction = pallet_transaction_payment::CurrencyAdapter<Balances, ()>; | ^^^^^^^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default
bound is defined in more than one place: runtime/testnet/src/extensions.rs#L32
warning: bound is defined in more than one place --> runtime/testnet/src/extensions.rs:32:10 | 32 | fn call<E: Ext>(&mut self, env: Environment<E, InitState>) -> Result<RetVal, DispatchError> | ^ 33 | where 34 | E: Ext<T = T>, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations = note: `#[warn(clippy::multiple_bound_locations)]` on by default
use of deprecated struct `pallet_transaction_payment::CurrencyAdapter`: Please use the fungible trait and FungibleAdapter. This struct will be removed some time after March 2024.: runtime/devnet/src/lib.rs#L351
warning: use of deprecated struct `pallet_transaction_payment::CurrencyAdapter`: Please use the fungible trait and FungibleAdapter. This struct will be removed some time after March 2024. --> runtime/devnet/src/lib.rs:351:57 | 351 | type OnChargeTransaction = pallet_transaction_payment::CurrencyAdapter<Balances, ()>; | ^^^^^^^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default
bound is defined in more than one place: runtime/devnet/src/extensions/mod.rs#L45
warning: bound is defined in more than one place --> runtime/devnet/src/extensions/mod.rs:45:10 | 45 | fn call<E: Ext>(&mut self, env: Environment<E, InitState>) -> Result<RetVal, DispatchError> | ^ 46 | where 47 | E: Ext<T = T>, | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations = note: `#[warn(clippy::multiple_bound_locations)]` on by default
useless conversion to the same type: `<T as pallet_assets::Config<<T as fungibles::pallet::Config>::AssetsInstance>>::AssetId`: pallets/api/src/fungibles/benchmarking.rs#L39
warning: useless conversion to the same type: `<T as pallet_assets::Config<<T as fungibles::pallet::Config>::AssetsInstance>>::AssetId` --> pallets/api/src/fungibles/benchmarking.rs:39:4 | 39 | asset.clone().into(), | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `asset.clone()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default