refactor: relocates primitives and contract examples (#35) #90
Annotations
9 warnings
lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
this function has too many arguments (15/7):
node/src/service.rs#L362
warning: this function has too many arguments (15/7)
--> node/src/service.rs:362:1
|
362 | / fn start_consensus(
363 | | client: Arc<ParachainClient>,
364 | | backend: Arc<ParachainBackend>,
365 | | block_import: ParachainBlockImport,
... |
377 | | announce_block: Arc<dyn Fn(Hash, Option<Vec<u8>>) + Send + Sync>,
378 | | ) -> Result<(), sc_service::Error> {
| |__________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
|
large size difference between variants:
node/src/cli.rs#L5
warning: large size difference between variants
--> node/src/cli.rs:5:1
|
5 | / pub enum Subcommand {
6 | | /// Build a chain specification.
7 | | BuildSpec(sc_cli::BuildSpecCmd),
8 | |
... |
19 | | ImportBlocks(sc_cli::ImportBlocksCmd),
| | ------------------------------------- the second-largest variant contains at least 240 bytes
... |
39 | | Benchmark(frame_benchmarking_cli::BenchmarkCmd),
| | ----------------------------------------------- the largest variant contains at least 512 bytes
... |
48 | | Key(sc_cli::KeySubcommand),
49 | | }
| |_^ the entire enum is at least 512 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
= note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
|
39 | Benchmark(Box<frame_benchmarking_cli::BenchmarkCmd>),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
useless conversion to the same type: `cumulus_primitives_core::Location`:
runtime/src/extensions.rs#L320
warning: useless conversion to the same type: `cumulus_primitives_core::Location`
--> runtime/src/extensions.rs:320:35
|
320 | .deposit_asset(assets.into(), beneficiary.into())
| ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `beneficiary`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
useless conversion to the same type: `cumulus_primitives_core::Asset`:
runtime/src/extensions.rs#L313
warning: useless conversion to the same type: `cumulus_primitives_core::Asset`
--> runtime/src/extensions.rs:313:20
|
313 | .buy_execution(assets.clone().into(), Unlimited)
| ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `assets.clone()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
clippy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, Swatinem/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|