feat(devnet): activate async backing #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #143 +/- ##
==========================================
- Coverage 10.60% 10.60% -0.01%
==========================================
Files 27 27
Lines 2131 2132 +1
Branches 2131 2132 +1
==========================================
Hits 226 226
- Misses 1905 1906 +1
|
SlotDuration set due to being enabled for devnet runtime and Rust's feature unification, requiring the setting of a backwards compatible value.
evilrobot-01
force-pushed
the
frank/devnet-async-backing
branch
from
fde96e3 to
7be1434
Compare
Daanvdplas
approved these changes
Aug 7, 2024
Daanvdplas
approved these changes
Aug 8, 2024
chungquantin
pushed a commit
to chungquantin/pop-node
that referenced
this pull request
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables async backing for the devnet runtime only, splitting the network config into two using the same name as the runtime. Certain constants had to be copied into the devnet runtime to be altered to as to not affect the testnet runtime.
Note: discovered that the testnet chainspec was using the devnet runtime, meaning the version on paseo may be using the devnet runtime with testnet state. I cant recall when we split the runtimes, and whether that was after the testnet launch, but precaution should be taken on the next onchain runtime upgrade.
It is suggested that apart from a review, both runtimes should be tested via pop up. We should also not merge this before the next runtime upgrade, just in case. I think it should be used for a bit on main first.