Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: deterministic build #146

Merged
merged 18 commits into from
Aug 4, 2024
Merged

ci: deterministic build #146

merged 18 commits into from
Aug 4, 2024

Conversation

Daanvdplas
Copy link
Collaborator

@Daanvdplas Daanvdplas commented Jul 29, 2024

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 3.30%. Comparing base (95bb4b5) to head (e123507).

@@          Coverage Diff          @@
##            main    #146   +/-   ##
=====================================
  Coverage   3.30%   3.30%           
=====================================
  Files         30      30           
  Lines       6843    6843           
  Branches    6843    6843           
=====================================
  Hits         226     226           
  Misses      6617    6617           

Copy link
Collaborator

@al3mart al3mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Daanvdplas Daanvdplas marked this pull request as draft July 30, 2024 08:19
@evilrobot-01
Copy link
Collaborator

evilrobot-01 commented Aug 1, 2024

Should be good now, at least from a manual run perspective. Example manual run, selecting the option to build runtimes only, at https://github.com/r0gue-io/pop-node/actions/runs/10207565037. Example of a test release at https://github.com/r0gue-io/pop-node/releases/tag/ci-test.

Note that a release will build both runtimes and node, whilst a manual trigger allows for selection of node and/or runtimes.

PS - the ci-test release and tag should be deleted before this is merged.

@evilrobot-01 evilrobot-01 marked this pull request as ready for review August 2, 2024 06:07
@evilrobot-01 evilrobot-01 requested a review from al3mart August 2, 2024 06:08
@chungquantin chungquantin linked an issue Aug 4, 2024 that may be closed by this pull request
@evilrobot-01 evilrobot-01 merged commit 6afad5c into main Aug 4, 2024
25 checks passed
@evilrobot-01 evilrobot-01 deleted the daan/ci-runtime_upgrade branch August 4, 2024 16:14
chungquantin pushed a commit to chungquantin/pop-node that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: deterministic build
5 participants