chore: upgrade to 1.14.0 #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade Polkadot version from 1.7.0 to 1.8.0
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #178 +/- ##
=========================================
- Coverage 10.60% 6.40% -4.20%
=========================================
Files 27 27
Lines 2132 1997 -135
Branches 2132 1997 -135
=========================================
- Hits 226 128 -98
+ Misses 1906 1869 -37
|
Upgrade Polkadot version from 1.7.0 to 1.8.0
chungquantin
requested review from
al3mart and
peterwht
and removed request for
al3mart and
peterwht
Co-authored-by: Peter White <[email protected]>
Daanvdplas
reviewed
Aug 21, 2024
chungquantin
commented
Aug 21, 2024
Daanvdplas
requested changes
Aug 21, 2024
|
I'm afraid there are multiple migrations required for pallet contracts. Automatic migration is what we are doing now and can only happen with single migrations. Edit: the pallet version is 15 so there should only be needed one (ED deposit migration) Not sure why it doesn't work |
|
#222 Fixed the above. |
Daanvdplas
approved these changes
Aug 21, 2024
al3mart
approved these changes
Aug 21, 2024
Daanvdplas
reviewed
Aug 22, 2024
|
|
||
| // debug_message weight is a good approximation of the additional overhead of going | ||
| // from contract layer to substrate layer. | ||
| // reference: https://github.com/paritytech/ink-examples/blob/b8d2caa52cf4691e0ddd7c919e4462311deb5ad0/psp22-extension/runtime/psp22-extension-example.rs#L236 | ||
| let overhead = contract_host_weight.debug_message; | ||
| // reference: https://github.com/paritytech/polkadot-sdk/pull/4233/files#:~:text=DebugMessage(len)%20%3D%3E%20T%3A%3AWeightInfo%3A%3Aseal_debug_message(len)%2C |
There was a problem hiding this comment.
Great work updating those references Tin!
There was a problem hiding this comment.
thank you 🙏
chungquantin
added a commit
that referenced
this pull request
Sep 6, 2024
Co-authored-by: Peter White <[email protected]> Co-authored-by: Daanvdplas <[email protected]> Co-authored-by: Alejandro Martinez Andres <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue: #141
Upgrade guidelines
major.minor.patchtodeveloper, the nextmajor.<minor + 1>.patchwill be rebased todeveloperand asking for approvals from the reviewers again.List of pull requests (merge in order)