refactor: error #192
Closed
refactor: error #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
Daanvdplas
force-pushed
the
daan/api
branch
2 times, most recently
from
5c36b4f to
6adf1b1
Compare
Daanvdplas
changed the base branch from
daan/api
to
daan/tests-increase_coverage
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## daan/tests-increase_coverage #192 +/- ##
================================================================
+ Coverage 32.76% 33.24% +0.47%
================================================================
Files 34 33 -1
Lines 2994 2951 -43
Branches 2994 2951 -43
================================================================
Hits 981 981
+ Misses 1980 1937 -43
Partials 33 33
|
|
No longer needed due to #218 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #204
Additionally it removes the pop primitives dependency from the extension crate since it is no longer needed. This should have been added to #211 but forgotten.