Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: conditional release builds #226

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

al3mart
Copy link
Collaborator

@al3mart al3mart commented Aug 21, 2024

  • Trigger the srtool build flow if the release has been tagged with runtime-*.
  • Trigger the release node build flow if the release has been tagged with node-*.

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.40%. Comparing base (c4e2a6d) to head (1078dc1).
Report is 3 commits behind head on main.

@@          Coverage Diff          @@
##            main    #226   +/-   ##
=====================================
  Coverage   6.40%   6.40%           
=====================================
  Files         27      27           
  Lines       1997    1997           
  Branches    1997    1997           
=====================================
  Hits         128     128           
  Misses      1869    1869           

see 19 files with indirect coverage changes

@al3mart
Copy link
Collaborator Author

al3mart commented Aug 27, 2024

Testing these changes triggering a the action to be run with:
gh workflow run "pop release" --ref node-conditional-test-release

The runtime build seems to be triggered anyway. - Maybe because this fulfills the condition of being trigger via workflow_dispatch.

@evilrobot-01
Copy link
Collaborator

Need to update to differentiate between the runtimes, so we can do just a testnet release (testnet-* tag), or just a mainnet release (mainnet-* tag). This should avoid all the noise which appears in the releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants