Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: spot order contract #39

Merged
merged 7 commits into from
Mar 12, 2024
Merged

feat: spot order contract #39

merged 7 commits into from
Mar 12, 2024

Conversation

peterwht
Copy link
Collaborator

@peterwht peterwht commented Mar 12, 2024

Also updates ink! deps to 5.0.0-rc3

@peterwht peterwht force-pushed the peter/feat-update-ink branch from 33f3dce to 9aa869f Compare March 12, 2024 07:06
@peterwht peterwht requested review from evilrobot-01 and Daanvdplas and removed request for evilrobot-01 March 12, 2024 07:07
@peterwht peterwht marked this pull request as ready for review March 12, 2024 07:07
@evilrobot-01
Copy link
Collaborator

Nice to see. 🙂

Not sure what dev environment you use, but check if you can get it to auto format files on save to save the additional hassle of waiting for ci to discover issues.

@evilrobot-01 evilrobot-01 force-pushed the peter/feat-update-ink branch from dc90ee2 to 16c201f Compare March 12, 2024 10:00
@evilrobot-01
Copy link
Collaborator

Rebased

Copy link
Collaborator

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will sort merging once CI checks successful

@evilrobot-01 evilrobot-01 changed the title feat: update ink deps to 5.0.0-rc3 feat: spot order contract Mar 12, 2024
@evilrobot-01 evilrobot-01 merged commit 0fce3f6 into main Mar 12, 2024
5 checks passed
@evilrobot-01 evilrobot-01 deleted the peter/feat-update-ink branch March 12, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants