-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: spot order contract #39
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterwht
force-pushed
the
peter/feat-update-ink
branch
from
March 12, 2024 07:06
33f3dce
to
9aa869f
Compare
peterwht
requested review from
evilrobot-01 and
Daanvdplas
and removed request for
evilrobot-01
March 12, 2024 07:07
Nice to see. 🙂 Not sure what dev environment you use, but check if you can get it to auto format files on save to save the additional hassle of waiting for ci to discover issues. |
evilrobot-01
force-pushed
the
peter/feat-update-ink
branch
from
March 12, 2024 10:00
dc90ee2
to
16c201f
Compare
Rebased |
evilrobot-01
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will sort merging once CI checks successful
evilrobot-01
changed the title
feat: update ink deps to 5.0.0-rc3
feat: spot order contract
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates ink! deps to 5.0.0-rc3