Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve comments & collection approvals logic #395

Merged

Conversation

chungquantin
Copy link
Collaborator

No description provided.

@chungquantin chungquantin merged commit b7d620e into chungquantin/feat-nfts Nov 27, 2024
13 checks passed
@chungquantin chungquantin deleted the chungquantin/fix-nfts_collection_approval branch November 27, 2024 11:01
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 74.80315% with 64 lines in your changes missing coverage. Please review.

Project coverage is 69.80%. Comparing base (5615f1b) to head (2832433).
Report is 1 commits behind head on chungquantin/feat-nfts.

Files with missing lines Patch % Lines
pallets/nfts/src/migration.rs 0.00% 53 Missing ⚠️
pallets/nfts/src/lib.rs 74.41% 3 Missing and 8 partials ⚠️
@@                    Coverage Diff                     @@
##           chungquantin/feat-nfts     #395      +/-   ##
==========================================================
- Coverage                   70.02%   69.80%   -0.22%     
==========================================================
  Files                          69       70       +1     
  Lines                       12415    12481      +66     
  Branches                    12415    12481      +66     
==========================================================
+ Hits                         8693     8712      +19     
- Misses                       3458     3507      +49     
+ Partials                      264      262       -2     
Files with missing lines Coverage Δ
pallets/nfts/src/features/approvals.rs 95.96% <100.00%> (+3.96%) ⬆️
...lets/nfts/src/features/create_delete_collection.rs 84.88% <100.00%> (ø)
pallets/nfts/src/features/create_delete_item.rs 89.44% <100.00%> (ø)
pallets/nfts/src/features/transfer.rs 84.78% <100.00%> (-0.74%) ⬇️
pallets/nfts/src/tests.rs 99.89% <100.00%> (+<0.01%) ⬆️
pallets/nfts/src/types.rs 67.11% <ø> (ø)
pallets/nfts/src/lib.rs 72.44% <74.41%> (-0.23%) ⬇️
pallets/nfts/src/migration.rs 0.00% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants