refactor: remove CollectionApprovalCount storage item
#396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## chungquantin/feat-nfts #396 +/- ##
==========================================================
- Coverage 69.96% 69.76% -0.20%
==========================================================
Files 70 70
Lines 12523 12431 -92
Branches 12523 12431 -92
==========================================================
- Hits 8762 8673 -89
Misses 3493 3493
+ Partials 268 265 -3
|
chungquantin
commented
Nov 29, 2024
| @@ -139,12 +139,12 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> { | |||
| /// The range of component `a` is `[0, 1000]`. | |||
| fn destroy(_m: u32, _c: u32, a: u32, ) -> Weight { | |||
There was a problem hiding this comment.
Weight diff destroy
chungquantin
commented
Nov 29, 2024
| /// Storage: `Nfts::Item` (r:1 w:1) | ||
| /// Proof: `Nfts::Item` (`max_values`: None, `max_size`: Some(861), added: 3336, mode: `MaxEncodedLen`) | ||
| /// Storage: `Nfts::CollectionApprovals` (r:21 w:20) | ||
| /// Storage: `Nfts::CollectionApprovals` (r:1 w:0) | ||
| /// Proof: `Nfts::CollectionApprovals` (`max_values`: None, `max_size`: Some(137), added: 2612, mode: `MaxEncodedLen`) | ||
| /// The range of component `i` is `[0, 1]`. | ||
| /// The range of component `n` is `[0, 20]`. | ||
| fn clear_all_transfer_approvals(i: u32, n: u32, ) -> Weight { |
There was a problem hiding this comment.
Weight diff clear_all_transfer_approvals
chungquantin
commented
Nov 29, 2024
| .saturating_add(Weight::from_parts(0, 2163).saturating_mul(i.into())) | ||
| } | ||
| /// Storage: `Nfts::Item` (r:1 w:1) | ||
| /// Proof: `Nfts::Item` (`max_values`: None, `max_size`: Some(861), added: 3336, mode: `MaxEncodedLen`) | ||
| /// Storage: `Nfts::CollectionApprovals` (r:1 w:0) | ||
| /// Proof: `Nfts::CollectionApprovals` (`max_values`: None, `max_size`: Some(137), added: 2612, mode: `MaxEncodedLen`) | ||
| /// Storage: `Nfts::CollectionApprovalCount` (r:2 w:2) | ||
| /// Proof: `Nfts::CollectionApprovalCount` (`max_values`: None, `max_size`: Some(73), added: 2548, mode: `MaxEncodedLen`) | ||
| /// The range of component `i` is `[0, 1]`. | ||
| fn cancel_approval(i: u32, ) -> Weight { |
There was a problem hiding this comment.
Weight diff cancel_approval
chungquantin
commented
Nov 29, 2024
| @@ -542,56 +542,49 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> { | |||
| /// Proof: `Nfts::CollectionConfigOf` (`max_values`: None, `max_size`: Some(73), added: 2548, mode: `MaxEncodedLen`) | |||
| /// Storage: `Nfts::CollectionApprovals` (r:1 w:1) | |||
| /// Proof: `Nfts::CollectionApprovals` (`max_values`: None, `max_size`: Some(137), added: 2612, mode: `MaxEncodedLen`) | |||
| /// Storage: `Nfts::CollectionApprovalCount` (r:2 w:2) | |||
| /// Proof: `Nfts::CollectionApprovalCount` (`max_values`: None, `max_size`: Some(73), added: 2548, mode: `MaxEncodedLen`) | |||
| /// The range of component `i` is `[0, 1]`. | |||
| fn approve_transfer(i: u32, ) -> Weight { | |||
There was a problem hiding this comment.
Weight diff approve_transfer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.