feat(pop-api): add call filter #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evilrobot-01
requested changes
Mar 24, 2024
Daanvdplas
approved these changes
Mar 25, 2024
al3mart
reviewed
Mar 25, 2024
We do not want to expose call_runtime directly because then we may break contracts with runtime upgrades. If we were to utilize the CallFilter in pallet-contracts, we would have to ONLY allow calls going into the Pop API pallet. Then we can filter a second layer in to ensure the next call is allowed |
al3mart
approved these changes
Mar 26, 2024
evilrobot-01
approved these changes
Mar 26, 2024
peterwht
force-pushed
the
peter/feat-api-call-filter
branch
from
2581118 to
b655413
Compare
al3mart
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an allowed list call filter to chain extension.
pallet-contracts'sCallFilteris not being used because it will allowb contracts to directly usecall_runtime. Once the pop api pallet is introduced, the call filter should be implemented there.There is a new example contract for testing purposes that tests that the call filter works.