-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: naming examples #79
Conversation
pop-api is included in the path, so having it in the contract names seems redundant. Simpler to just remove the |
f77f2bb
to
5c00397
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I would remove the pop_api_
or PopApi
prefix and just name it according to the name of the top level folder.
Similar to https://github.com/paritytech/ink-examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
CI is failing but haven't spent much time figuring why
a890520
to
dd2c836
Compare
Closed by #86 |
There was a warning in compiling a contract when adding pop api dependency. This should resolve it.
I also updated the naming, which we can use to move forward with the examples.
This is just naming things, examples need a lot more work.