Skip to content
Build, test and lint

fix: add missing import (#36) #83

Sign in to view logs

fix: add missing import (#36)

fix: add missing import (#36) #83

GitHub Actions / clippy succeeded Mar 10, 2024 in 0s

clippy

4 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 4
Note 0
Help 0

Versions

  • rustc 1.76.0 (07dca489a 2024-02-04)
  • cargo 1.76.0 (c84b36747 2024-01-18)
  • clippy 0.1.76 (07dca48 2024-02-04)

Annotations

Check warning on line 378 in node/src/service.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (15/7) 

warning: this function has too many arguments (15/7)
   --> node/src/service.rs:362:1
    |
362 | / fn start_consensus(
363 | |     client: Arc<ParachainClient>,
364 | |     backend: Arc<ParachainBackend>,
365 | |     block_import: ParachainBlockImport,
...   |
377 | |     announce_block: Arc<dyn Fn(Hash, Option<Vec<u8>>) + Send + Sync>,
378 | | ) -> Result<(), sc_service::Error> {
    | |__________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
    = note: `#[warn(clippy::too_many_arguments)]` on by default

Check warning on line 49 in node/src/cli.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

large size difference between variants 

warning: large size difference between variants
  --> node/src/cli.rs:5:1
   |
5  | / pub enum Subcommand {
6  | |     /// Build a chain specification.
7  | |     BuildSpec(sc_cli::BuildSpecCmd),
8  | |
...  |
19 | |     ImportBlocks(sc_cli::ImportBlocksCmd),
   | |     ------------------------------------- the second-largest variant contains at least 240 bytes
...  |
39 | |     Benchmark(frame_benchmarking_cli::BenchmarkCmd),
   | |     ----------------------------------------------- the largest variant contains at least 512 bytes
...  |
48 | |     Key(sc_cli::KeySubcommand),
49 | | }
   | |_^ the entire enum is at least 512 bytes
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
   = note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
   |
39 |     Benchmark(Box<frame_benchmarking_cli::BenchmarkCmd>),
   |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check warning on line 316 in runtime/src/extensions.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `cumulus_primitives_core::Location` 

warning: useless conversion to the same type: `cumulus_primitives_core::Location`
   --> runtime/src/extensions.rs:316:35
    |
316 |                 .deposit_asset(assets.into(), beneficiary.into())
    |                                               ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `beneficiary`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check warning on line 309 in runtime/src/extensions.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `cumulus_primitives_core::Asset` 

warning: useless conversion to the same type: `cumulus_primitives_core::Asset`
   --> runtime/src/extensions.rs:309:20
    |
309 |                 .buy_execution(assets.clone().into(), Unlimited)
    |                                ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `assets.clone()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `#[warn(clippy::useless_conversion)]` on by default
View more details on GitHub Actions