Skip to content
Lint PR

feat: api fungibles pallet #132

Sign in to view logs

feat: api fungibles pallet

feat: api fungibles pallet #132

GitHub Actions / clippy failed Jul 22, 2024 in 0s

clippy

1 error, 6 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 1
Warning 6
Note 0
Help 0

Versions

  • rustc 1.79.0 (129f3b996 2024-06-10)
  • cargo 1.79.0 (ffa9cf99a 2024-06-03)
  • clippy 0.1.79 (129f3b9 2024-06-10)

Annotations

Check warning on line 351 in runtime/devnet/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of deprecated struct `pallet_transaction_payment::CurrencyAdapter`: Please use the fungible trait and FungibleAdapter. This struct will be removed some time after March 2024. 

warning: use of deprecated struct `pallet_transaction_payment::CurrencyAdapter`: Please use the fungible trait and FungibleAdapter. This struct will be removed some time after March 2024.
   --> runtime/devnet/src/lib.rs:351:57
    |
351 |     type OnChargeTransaction = pallet_transaction_payment::CurrencyAdapter<Balances, ()>;
    |                                                            ^^^^^^^^^^^^^^^
    |
    = note: `#[warn(deprecated)]` on by default

Check warning on line 45 in runtime/devnet/src/extensions/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

bound is defined in more than one place 

warning: bound is defined in more than one place
  --> runtime/devnet/src/extensions/mod.rs:45:10
   |
45 |     fn call<E: Ext>(&mut self, env: Environment<E, InitState>) -> Result<RetVal, DispatchError>
   |             ^
46 |     where
47 |         E: Ext<T = T>,
   |         ^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
   = note: `#[warn(clippy::multiple_bound_locations)]` on by default

Check warning on line 340 in runtime/testnet/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of deprecated struct `pallet_transaction_payment::CurrencyAdapter`: Please use the fungible trait and FungibleAdapter. This struct will be removed some time after March 2024. 

warning: use of deprecated struct `pallet_transaction_payment::CurrencyAdapter`: Please use the fungible trait and FungibleAdapter. This struct will be removed some time after March 2024.
   --> runtime/testnet/src/lib.rs:340:57
    |
340 |     type OnChargeTransaction = pallet_transaction_payment::CurrencyAdapter<Balances, ()>;
    |                                                            ^^^^^^^^^^^^^^^
    |
    = note: `#[warn(deprecated)]` on by default

Check warning on line 33 in runtime/testnet/src/extensions.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

bound is defined in more than one place 

warning: bound is defined in more than one place
  --> runtime/testnet/src/extensions.rs:33:10
   |
33 |     fn call<E: Ext>(&mut self, env: Environment<E, InitState>) -> Result<RetVal, DispatchError>
   |             ^
34 |     where
35 |         E: Ext<T = T>,
   |         ^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
   = note: `#[warn(clippy::multiple_bound_locations)]` on by default

Check failure on line 9 in runtime/testnet/src/extensions.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

failed to resolve: use of undeclared crate or module `pop_primitives` 

error[E0433]: failed to resolve: use of undeclared crate or module `pop_primitives`
 --> runtime/testnet/src/extensions.rs:9:5
  |
9 | use pop_primitives::storage_keys::RuntimeStateKeys;
  |     ^^^^^^^^^^^^^^ use of undeclared crate or module `pop_primitives`
  |
help: there is a crate or module with a similar name
  |
9 | use primitives::storage_keys::RuntimeStateKeys;
  |     ~~~~~~~~~~

Check warning on line 54 in scripts/fund-dev-accounts/./main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used a field initializer for a tuple struct 

warning: used a field initializer for a tuple struct
  --> scripts/fund-dev-accounts/./main.rs:54:9
   |
54 |                 id: AssetId { 0: Location { parents: 0, interior: Junctions::Here } },
   |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `AssetId(Location { parents: 0, interior: Junctions::Here })`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#init_numbered_fields

Check warning on line 57 in scripts/fund-dev-accounts/./main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used a field initializer for a tuple struct 

warning: used a field initializer for a tuple struct
  --> scripts/fund-dev-accounts/./main.rs:52:36
   |
52 |           let assets = VersionedAssets::V4(Assets {
   |  __________________________________________^
53 | |             0: vec![Asset {
54 | |                 id: AssetId { 0: Location { parents: 0, interior: Junctions::Here } },
55 | |                 fun: amount,
56 | |             }],
57 | |         });
   | |_________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#init_numbered_fields
   = note: `#[warn(clippy::init_numbered_fields)]` on by default
help: try
   |
52 ~         let assets = VersionedAssets::V4(Assets(<[_]>::into_vec(
53 +             // This rustc_box is not required, but it produces a dramatic improvement in compile
54 +             // time when constructing arrays with many elements.
55 +             #[rustc_box]
56 +             $crate::boxed::Box::new([$($x),+])
57 ~         )));
   |
View more details on GitHub Actions