Skip to content

feat(spike): cross-chain nonfungible implementation #2045

feat(spike): cross-chain nonfungible implementation

feat(spike): cross-chain nonfungible implementation #2045

GitHub Actions / clippy succeeded Dec 13, 2024 in 5s

clippy

255 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 255
Note 0
Help 0

Versions

  • rustc 1.83.0 (90b35a623 2024-11-26)
  • cargo 1.83.0 (5ffbef321 2024-10-29)
  • clippy 0.1.83 (90b35a6 2024-11-26)

Annotations

Check warning on line 44 in node/src/cli.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

large size difference between variants

warning: large size difference between variants
  --> node/src/cli.rs:5:1
   |
5  | / pub enum Subcommand {
6  | |     /// Build a chain specification.
7  | |     BuildSpec(sc_cli::BuildSpecCmd),
...  |
19 | |     ImportBlocks(sc_cli::ImportBlocksCmd),
   | |     ------------------------------------- the second-largest variant contains at least 240 bytes
...  |
39 | |     Benchmark(frame_benchmarking_cli::BenchmarkCmd),
   | |     ----------------------------------------------- the largest variant contains at least 544 bytes
...  |
43 | |     Key(sc_cli::KeySubcommand),
44 | | }
   | |_^ the entire enum is at least 544 bytes
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
   = note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
   |
39 |     Benchmark(Box<frame_benchmarking_cli::BenchmarkCmd>),
   |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check warning on line 34 in node/src/rpc.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `backend` is never read

warning: field `backend` is never read
  --> node/src/rpc.rs:34:6
   |
26 | pub struct FullDeps<C, P, B> {
   |            -------- field in this struct
...
34 |     pub backend: Arc<B>,
   |         ^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

Check warning on line 171 in runtime/devnet/src/config/xcm.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
   --> runtime/devnet/src/config/xcm.rs:171:1
    |
171 | pub struct XcmConfig;
    | ^^^^^^^^^^^^^^^^^^^^

Check warning on line 169 in runtime/devnet/src/config/xcm.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a type alias

warning: missing documentation for a type alias
   --> runtime/devnet/src/config/xcm.rs:169:1
    |
169 | pub type TrustedReserves = (NativeAsset, NativeAssetFrom<AssetHub>);
    | ^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 144 in runtime/devnet/src/config/xcm.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a type alias

warning: missing documentation for a type alias
   --> runtime/devnet/src/config/xcm.rs:144:1
    |
144 | pub type Barrier = TrailingSetTopicAsId<(
    | ^^^^^^^^^^^^^^^^

Check warning on line 137 in runtime/devnet/src/config/xcm.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
   --> runtime/devnet/src/config/xcm.rs:137:1
    |
137 | pub struct ParentOrParentsExecutivePlurality;
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 265 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
   --> runtime/devnet/src/config/xcm.rs:130:1
    |
130 | / parameter_types! {
131 | |     // One XCM operation is 1_000_000_000 weight - almost certainly a conservative estimate.
132 | |     pub UnitWeightCost: Weight = Weight::from_parts(1_000_000_000, 64 * 1024);
133 | |     pub const MaxInstructions: u32 = 100;
134 | |     pub const MaxAssetsIntoHolding: u32 = 64;
135 | | }
    | |_^
    |
    = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 265 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
   --> runtime/devnet/src/config/xcm.rs:130:1
    |
130 | / parameter_types! {
131 | |     // One XCM operation is 1_000_000_000 weight - almost certainly a conservative estimate.
132 | |     pub UnitWeightCost: Weight = Weight::from_parts(1_000_000_000, 64 * 1024);
133 | |     pub const MaxInstructions: u32 = 100;
134 | |     pub const MaxAssetsIntoHolding: u32 = 64;
135 | | }
    | |_^
    |
    = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 277 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
   --> runtime/devnet/src/config/xcm.rs:130:1
    |
130 | / parameter_types! {
131 | |     // One XCM operation is 1_000_000_000 weight - almost certainly a conservative estimate.
132 | |     pub UnitWeightCost: Weight = Weight::from_parts(1_000_000_000, 64 * 1024);
133 | |     pub const MaxInstructions: u32 = 100;
134 | |     pub const MaxAssetsIntoHolding: u32 = 64;
135 | | }
    | |_^
    |
    = note: this warning originates in the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 115 in runtime/devnet/src/config/xcm.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a type alias

warning: missing documentation for a type alias
   --> runtime/devnet/src/config/xcm.rs:115:1
    |
115 | pub type NonFungiblesTransactor = NonFungiblesAdapterPop<
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 94 in runtime/devnet/src/config/xcm.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/devnet/src/config/xcm.rs:94:1
   |
94 | pub struct MultiAssetToNftsConverter;
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 277 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/devnet/src/config/xcm.rs:35:1
   |
35 | / parameter_types! {
36 | |     pub const RelayLocation: Location = Location::parent();
37 | |     pub AssetHub: Location = Location::new(1, [Parachain(1000)]);
38 | |     // Note: Paseo currently uses Polkadot https://github.com/paseo-network/runtimes/blob/abc4ae9c5ae8f0166aab7ef2b427b3c2c6d5ce5c/relay/...
...  |
43 | |     pub UniversalLocation: InteriorLocation = Parachain(ParachainInfo::parachain_id().into()).into();
44 | | }
   | |_^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 277 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/devnet/src/config/xcm.rs:35:1
   |
35 | / parameter_types! {
36 | |     pub const RelayLocation: Location = Location::parent();
37 | |     pub AssetHub: Location = Location::new(1, [Parachain(1000)]);
38 | |     // Note: Paseo currently uses Polkadot https://github.com/paseo-network/runtimes/blob/abc4ae9c5ae8f0166aab7ef2b427b3c2c6d5ce5c/relay/...
...  |
43 | |     pub UniversalLocation: InteriorLocation = Parachain(ParachainInfo::parachain_id().into()).into();
44 | | }
   | |_^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 265 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/devnet/src/config/xcm.rs:35:1
   |
35 | / parameter_types! {
36 | |     pub const RelayLocation: Location = Location::parent();
37 | |     pub AssetHub: Location = Location::new(1, [Parachain(1000)]);
38 | |     // Note: Paseo currently uses Polkadot https://github.com/paseo-network/runtimes/blob/abc4ae9c5ae8f0166aab7ef2b427b3c2c6d5ce5c/relay/...
...  |
43 | |     pub UniversalLocation: InteriorLocation = Parachain(ParachainInfo::parachain_id().into()).into();
44 | | }
   | |_^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 277 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/devnet/src/config/xcm.rs:35:1
   |
35 | / parameter_types! {
36 | |     pub const RelayLocation: Location = Location::parent();
37 | |     pub AssetHub: Location = Location::new(1, [Parachain(1000)]);
38 | |     // Note: Paseo currently uses Polkadot https://github.com/paseo-network/runtimes/blob/abc4ae9c5ae8f0166aab7ef2b427b3c2c6d5ce5c/relay/...
...  |
43 | |     pub UniversalLocation: InteriorLocation = Parachain(ParachainInfo::parachain_id().into()).into();
44 | | }
   | |_^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 265 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/devnet/src/config/xcm.rs:35:1
   |
35 | / parameter_types! {
36 | |     pub const RelayLocation: Location = Location::parent();
37 | |     pub AssetHub: Location = Location::new(1, [Parachain(1000)]);
38 | |     // Note: Paseo currently uses Polkadot https://github.com/paseo-network/runtimes/blob/abc4ae9c5ae8f0166aab7ef2b427b3c2c6d5ce5c/relay/...
...  |
43 | |     pub UniversalLocation: InteriorLocation = Parachain(ParachainInfo::parachain_id().into()).into();
44 | | }
   | |_^
   |
   = note: this warning originates in the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 166 in runtime/devnet/src/config/assets.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a type alias

warning: missing documentation for a type alias
   --> runtime/devnet/src/config/assets.rs:166:1
    |
166 | pub type TrustBackedAssetsCall = pallet_assets::Call<Runtime, TrustBackedAssetsInstance>;
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 277 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
   --> runtime/devnet/src/config/assets.rs:139:1
    |
139 | / parameter_types! {
140 | |     pub const NftFractionalizationPalletId: PalletId = PalletId(*b"fraction");
141 | |     pub NewAssetSymbol: BoundedVec<u8, AssetsStringLimit> = (*b"FRAC").to_vec().try_into().unwrap();
142 | |     pub NewAssetName: BoundedVec<u8, AssetsStringLimit> = (*b"Frac").to_vec().try_into().unwrap();
143 | | }
    | |_^
    |
    = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 277 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
   --> runtime/devnet/src/config/assets.rs:139:1
    |
139 | / parameter_types! {
140 | |     pub const NftFractionalizationPalletId: PalletId = PalletId(*b"fraction");
141 | |     pub NewAssetSymbol: BoundedVec<u8, AssetsStringLimit> = (*b"FRAC").to_vec().try_into().unwrap();
142 | |     pub NewAssetName: BoundedVec<u8, AssetsStringLimit> = (*b"Frac").to_vec().try_into().unwrap();
143 | | }
    | |_^
    |
    = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 265 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
   --> runtime/devnet/src/config/assets.rs:139:1
    |
139 | / parameter_types! {
140 | |     pub const NftFractionalizationPalletId: PalletId = PalletId(*b"fraction");
141 | |     pub NewAssetSymbol: BoundedVec<u8, AssetsStringLimit> = (*b"FRAC").to_vec().try_into().unwrap();
142 | |     pub NewAssetName: BoundedVec<u8, AssetsStringLimit> = (*b"Frac").to_vec().try_into().unwrap();
143 | | }
    | |_^
    |
    = note: this warning originates in the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 104 in runtime/devnet/src/config/assets.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a type alias

warning: missing documentation for a type alias
   --> runtime/devnet/src/config/assets.rs:104:1
    |
104 | pub type TrustBackedNftsCall = pallet_nfts::Call<Runtime, TrustBackedNftsInstance>;
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 68 in runtime/devnet/src/config/assets.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a type alias

warning: missing documentation for a type alias
  --> runtime/devnet/src/config/assets.rs:68:1
   |
68 | pub type ForeignNftsCall = pallet_nfts::Call<Runtime, ForeignNftsInstance>;
   | ^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 45 in runtime/devnet/src/config/assets.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/devnet/src/config/assets.rs:45:1
   |
45 | pub struct ForeignCreatorsNfts;
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 265 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/devnet/src/config/assets.rs:33:1
   |
33 | / parameter_types! {
34 | |     pub NftsPalletFeatures: PalletFeatures = PalletFeatures::all_enabled();
35 | |     pub const NftsCollectionDeposit: Balance = 10 * UNIT;
36 | |     // Key = 116 bytes (4+16+32+16+32+16), Value = 17 bytes (1+8+8)
...  |
42 | |     pub const NftsMaxDeadlineDuration: BlockNumber = 12 * 30 * DAYS;
43 | | }
   | |_^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 265 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/devnet/src/config/assets.rs:33:1
   |
33 | / parameter_types! {
34 | |     pub NftsPalletFeatures: PalletFeatures = PalletFeatures::all_enabled();
35 | |     pub const NftsCollectionDeposit: Balance = 10 * UNIT;
36 | |     // Key = 116 bytes (4+16+32+16+32+16), Value = 17 bytes (1+8+8)
...  |
42 | |     pub const NftsMaxDeadlineDuration: BlockNumber = 12 * 30 * DAYS;
43 | | }
   | |_^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)