Implement thorough check and test in xtask #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cargo xtask check` depends on having installed `<arch>-unknown-linux-gnu` for each supported arch via `rustup`, otherwise the relevant check is not run. Also changes the riscv target from riscvimac to riscvgc so that we have better toolchain support. Signed-off-by: Graham MacDonald <[email protected]>
gmacd
force-pushed
the
2023-11-12-check-and-test
branch
from
526a075 to
12ebc38
Compare
dancrossnyc
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo xtask checkdepends on having installed<arch>-unknown-linux-gnufor each supported arch viarustup, otherwise the relevant check is not run.Also changes the riscv target from riscvimac to riscvgc so that we have better toolchain support.
Github actions runs the x86-64 tests. If it ever supports aarch64 or riscv64 runners, we could also have it run these tests.