Restructure xtask, fix flag parsing #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate build into most distinct stages, each with their own argument parsing. This suits clap better, and makes each step independent. Combine qemu and qemukvm. Fix parsing of profile flag arg (probably amongst others) - was always building in release mode. Tidy memory map output in aarch64 by sorting. Signed-off-by: Graham MacDonald <[email protected]>
Signed-off-by: Graham MacDonald <[email protected]>
orangecms
approved these changes
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate build into most distinct stages, each with their own argument parsing. This suits clap better, and makes each step independent.
Combine qemu and qemukvm.
Fix parsing of profile flag arg (probably amongst others) - was always building in release mode.
Tidy memory map output in aarch64 by sorting.