riscv64: use SBI SRST extension instead of legacy SBI for system shutdown #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…down Legacy SBI have been deprecated years ago (on Jun 9, 2021). Modern RISC-V SBI firmware would use SBI SRST extension to shutdown an S-mode environment; we use `sbi-rt` crate for this purpose. Unused feature gate `opensbi` is removed, as RISC-V SBI support does not usually satisfy which implementation we'd use, unless e.g. fixing implementation-specific bugs. Signed-off-by: Zhouqi Jiang <[email protected]>
orangecms
approved these changes
Oct 24, 2024
|
Awesome, thank you! :) |
|
Thanks for the PR! (I hope you don't mind me merging) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legacy SBI have been deprecated years ago (on Jun 9, 2021). Modern RISC-V SBI firmware would use SBI SRST extension to shutdown an S-mode environment; we use
sbi-rtcrate for this purpose.Unused feature gate
opensbiis removed, as RISC-V SBI support does not usually satisfy which implementation we'd use, unless e.g. fixing implementation-specific bugs.QEMU RISC-V test result (shutdown procedure works as expected):
r? @gmacd