Deprecate closure style render method

ra1028 · Sep 4, 2019 · 34b9828 · 34b9828
1 parent f95c1b6
commit 34b9828
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 0 deletions.
diff --git a/Sources/Renderer.swift b/Sources/Renderer.swift
@@ -102,6 +102,7 @@ open class Renderer<Updater: Carbon.Updater> {
     ///
     /// - Parameters:
     ///   - buildData: A closure to build sections.
+    @available(*, deprecated, message: "This method will be removed next version owing to avoid ambiguity with new syntax using function builder.")
     open func render(_ buildData: (inout [Section]) -> Void) {
         var data = [Section]()
         buildData(&data)

diff --git a/Sources/Section.swift b/Sources/Section.swift
@@ -69,6 +69,7 @@ public struct Section {
     /// - Parameters:
     ///   - id: An identifier to be wrapped.
     ///   - buildSection: A closure to build section.
+    @available(*, deprecated, message: "This method will be removed next version owing to avoid ambiguity with new syntax using function builder.")
     @inlinable
     public init<I: Hashable>(id: I, _ buildSection: (inout Section) -> Void) {
         var section = Section(id: id)

diff --git a/Tests/RendererTests.swift b/Tests/RendererTests.swift
@@ -156,6 +156,7 @@ final class RendererTests: XCTestCase {
         XCTAssertEqual(renderer.updater.adapterCapturedOnUpdates, adapter)
     }
 
+    @available(*, deprecated)
     func testRenderWithBuilderClosure() {
         let target = MockTarget()
         let adapter = MockAdapter()

diff --git a/Tests/SectionTests.swift b/Tests/SectionTests.swift
@@ -33,6 +33,7 @@ final class SectionTests: XCTestCase {
         XCTAssertEqual(section.cells.count, 2)
     }
 
+    @available(*, deprecated)
     func testInitWithBuilderClosure() {
         let section = Section(id: TestID.a) { section in
             section.header = ViewNode(A.Component())