Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme for RubyKaigi 2024 #160

Closed

Conversation

hasumikin
Copy link
Contributor

This PR is to provide the theme for RubyKaigi 2024.

I can merge this PR by myself though, I'd like to review it by @kou because this is the first time sending a PR of a theme.

As in, I want to ask one thing: Can "theme" also have slide size as a property? (I always specify the size like bundle exec rabbit --size=1920,1200 my_slide.rab. But I'm wondering if I can configure the size in my_theme.rb or somewhere like that)


Anyway, the example looks like below:

Your Awesome Title - Subtitle Goes So Cool-0
Your Awesome Title - Subtitle Goes So Cool-1
Your Awesome Title - Subtitle Goes So Cool-2
Your Awesome Title - Subtitle Goes So Cool-3

@hasumikin hasumikin requested a review from kou April 15, 2024 05:56
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I create a project for Rabbit slide by rabbit-slide new ....
For this case, we can use rabbit-slide new --width 1920 --height 1200 ....
For example: https://gitlab.com/ktou/rabbit-slide-kou-rubykaigi-2023

We can show the slide by rake in the project directory. (We can release the slide by rake publish:rubygems.)

BTW, we can create a new repository for this instead of putting this to this repository. For example:

If we use separated repository, we can release this theme as a gem like https://rubygems.org/gems/rabbit-theme-clear-code .
Users can install this theme as a gem like https://gitlab.com/ktou/rabbit-slide-kou-rubykaigi-2023/-/blob/main/Rakefile?ref_type=heads#L10 .

data/rabbit/image/rubykaigi2024-images/property.rb Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-rubykaigi2024-images
+rubykaigi-2024-images

lib/rabbit/theme/rubykaigi2024/property.rb Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-rubykaigi2024
+rubykaigi-2024

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use - as word separator for file name:

-slide_background.png
+slide-background.png

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-rubykaigi2024/rubykaigi2024.rb
+rubykaigi-2024/rubykaigi-2024.rb

Comment on lines 98 to 100
@item_image_1 = 'bullet-point-36.png'
@item_image_2 = 'bullet-point-32.png'
@item_image_3 = 'bullet-point-28.png'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can move them before include_theme("default") and remove the below include_theme("default-item-mark") because default-item-mark is included in default.

sample/rubykaigi2024.rab Outdated Show resolved Hide resolved
sample/rubykaigi2024.rab Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use Markdown if you always use Markdown for your slide. :-)

@hasumikin
Copy link
Contributor Author

rabbit-slide new --width 1920 --height 1200

Ah, I learned .rabbit file includes --size 1920,1200....!

@hasumikin hasumikin force-pushed the theme-RubyKaigi2024 branch from 6a0046a to 5247210 Compare April 15, 2024 08:21
@hasumikin
Copy link
Contributor Author

(Now I'm learning how to make an individual theme gem)

@kou
Copy link
Member

kou commented Apr 15, 2024

rabbit-theme new ... will generate a theme gem template but it may not work now...

@hasumikin
Copy link
Contributor Author

I don't have time right now, so I'll close it for now 🙇
Let me rethink

@hasumikin hasumikin closed this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants