-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make-visible
: use port-name-matches?
for symbols
#708
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resyntax analyzed 1 file in this pull request and found no issues.
I'm not sure if I'm missing something here, but I think that |
I don't know. The new code is simply to guarantee that the existing code path does not change because I don't understand the code. |
I did only some basic testing, but maybe something like this?
I can push that to your branch, I think, if you want to try it? What do you think? |
Sure! Please feel free to apply any changes. I don't have any idea about the appropriate code organization. |
Does |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resyntax analyzed 1 file in this pull request and found no issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resyntax analyzed 1 file in this pull request and found no issues.
This is ready, I think? |
It doesn't! And I see there was some conversion code in there before my change. I'll bring that back and merge it. |
a878209
to
b825a81
Compare
And fallback to find-matching-tab for path-strings? like before. Releated to racket/drracket@d27a480.
b825a81
to
23130b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resyntax analyzed 1 file in this pull request and found no issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resyntax analyzed 1 file in this pull request and found no issues.
When given symbols, they could be names for unsaved buffers. Directly match the definition window and the interaction window instead. Otherwise, fallback to
find-matching-tab
forpath-strings?
like before.Related to d27a480.