Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add name filter #196

Merged
merged 4 commits into from
Jun 27, 2024
Merged

add name filter #196

merged 4 commits into from
Jun 27, 2024

Conversation

andre-merzky
Copy link
Member

This implements #193

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 18.51852% with 22 lines in your changes missing coverage. Please review.

Project coverage is 21.89%. Comparing base (24dd105) to head (3c7dfb2).
Report is 18 commits behind head on devel.

Files with missing lines Patch % Lines
src/radical/analytics/session.py 13.04% 20 Missing ⚠️
src/radical/analytics/entity.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #196      +/-   ##
==========================================
- Coverage   22.14%   21.89%   -0.25%     
==========================================
  Files           7        7              
  Lines        1138     1160      +22     
==========================================
+ Hits          252      254       +2     
- Misses        886      906      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mtitov mtitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

p.s., just to keep in mind that pilot also should be part of the filtering
(a) either with uids

session.filter(uid=task_uids + [pid], inplace=False)

(b) or with patterns (using names)

name_pattern = re.compile(f'^(task.*{pipeline_uid}.*|pilot.*)$')
new_session  = session.filter(name=name_pattern, inplace=False)

@andre-merzky andre-merzky merged commit 00aaa00 into devel Jun 27, 2024
4 of 5 checks passed
@andre-merzky andre-merzky deleted the feature/name_filter branch June 27, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants