ci: adjust how cors is set

radicand · Jul 28, 2024 · 265d4cf · 265d4cf
1 parent 71535be
commit 265d4cf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/.github/workflows/release-api.yaml b/.github/workflows/release-api.yaml
@@ -46,9 +46,6 @@ on:
       HASURA_ADMIN_SECRET:
         description: 'Hasura Admin Secret'
         required: true
-      HASURA_CORS_DOMAINS:
-        description: 'Hasura CORS Domains'
-        required: true
 jobs:
   build:
     environment:
@@ -118,7 +115,7 @@ jobs:
 
       - name: Deploy
         run: |
-          helm upgrade cookbookery-api-production ./server/hasura/manifest/cookbook-hasura --install -n cookbook --set image.repository=ghcr.io/radicand/cookbookery-api --set image.tag=${{ steps.tagdata.outputs.tag }} --set dbUrl=${{ secrets.DATABASE_URL }} --set metadataDbUrl=${{ secrets.METADATA_DB_URL }} --set jwtSecret.audience=${{ secrets.JWT_AUD }} --set jwtSecret.issuer=${{ secrets.JWT_ISS }} --set jwtSecret.jwk_url=${{ secrets.JWT_JWKS }} --set adminSecret="${{ secrets.HASURA_ADMIN_SECRET }}" --set corsDomains="${{ secrets.HASURA_CORS_DOMAINS }}" --set ingress.host=${{ steps.envurl.outputs.url }} --set CI_PROJECT_PATH_SLUG=${{ github.ref_name }} --set CI_ENVIRONMENT_SLUG=production
+          helm upgrade cookbookery-api-production ./server/hasura/manifest/cookbook-hasura --install -n cookbook --set image.repository=ghcr.io/radicand/cookbookery-api --set image.tag=${{ steps.tagdata.outputs.tag }} --set dbUrl=${{ secrets.DATABASE_URL }} --set metadataDbUrl=${{ secrets.METADATA_DB_URL }} --set jwtSecret.audience=${{ secrets.JWT_AUD }} --set jwtSecret.issuer=${{ secrets.JWT_ISS }} --set jwtSecret.jwk_url=${{ secrets.JWT_JWKS }} --set adminSecret="${{ secrets.HASURA_ADMIN_SECRET }}" --set corsDomains="${{ vars.HASURA_CORS_DOMAINS }}" --set ingress.host=${{ steps.envurl.outputs.url }} --set CI_PROJECT_PATH_SLUG=${{ github.ref_name }} --set CI_ENVIRONMENT_SLUG=production
         env:
           KUBECONFIG: .kubeconfig
 

diff --git a/.github/workflows/release-please.yaml b/.github/workflows/release-please.yaml
@@ -39,6 +39,7 @@ jobs:
     secrets: inherit
     with:
       tag_name: ${{needs.release-please.outputs.api--tag_name}}
+
 
   release-app:
     if: ${{needs.release-please.outputs.app--release_created}}