Adding start and end time in cucumber json #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fliiiix
reviewed
Nov 21, 2024
| @@ -89,7 +89,7 @@ def generate_ccjson(self, features, marker): | |||
| "keyword": step.sentence.split()[0], | |||
| "name": step.sentence, | |||
| "line": step.line, | |||
| "result": {"status": step.state, "duration": duration}, | |||
| "result": {"status": step.state, "duration": duration,"starttime": str( step.starttime if step.starttime else 0.0), "endtime": str( step.endtime if step.endtime else 0.0)}, | |||
There was a problem hiding this comment.
what is the case where step.starttime or step.endtime are not truthy? and is 0.0 a good default?
There was a problem hiding this comment.
i don't think thats valid according to the cucumber spec https://github.com/cucumber/messages/blob/main/messages.md#teststepresult
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #474 +/- ##
=======================================
Coverage 87.25% 87.25%
=======================================
Files 39 39
Lines 2377 2377
=======================================
Hits 2074 2074
Misses 303 303
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
Also please run |
|
And please add a note for the change to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR is a part of #473
Describe Your Changes
adding start and end time of the step in cucumber.json
fixes #473