Fix .. cluster number for first-level dirs #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, indeed. I had one more error, which seemed like a larger undertaking to fix: EDIT: this was probably caused by me not dropping the fs object before running fsck, because it does not reproduce in the newly added test. |
badicsalex
force-pushed
the
fix-cluster-number-for-dotdot
branch
2 times, most recently
from
5e64b19
to
dd867af
Compare
|
Added a very simple |
The current code makes invalid dir entries, because the first two slots
should be . and .., but with LFNs, it's
LFN for .
.
LFN for ..
..
We should probably not create LFN's when not needed anyway, but that's not
implemented in this patch.
On FAT32, the cluster number of / is 0 in dir entries (and not the actually used cluster)
badicsalex
force-pushed
the
fix-cluster-number-for-dotdot
branch
from
dd867af
to
8becd5f
Compare
rafalh
approved these changes
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On FAT32, the cluster number of the root directory is 0 in dir entries (and not the actually used cluster)