-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
folder name change #73
base: master
Are you sure you want to change the base?
Conversation
Is the intention to keep this around just as a historical artifact, or to continue to maintain it? In a lot of ways I would like to get this out of the master branch altogether if we aren't going to continue to maintain it, which I think was our original plan. Then to keep this around as a historical artifact, we could make a branch (name it whatever we want) and leave the old configs around forever there. And of course link to that from wherever. If we want to keep this in the master branch long-term, we probably need a better name than either "unmaintained" or "original" - and we need to identify who is going to take care of it (not me). |
I think it depends on how we want this GitHub to be known. Unless or until Project R3D starts to use a config from here, it'll remain, "that GitHub that a bunch of cool people maintain, but has a different config than 90% of the RailCore's out there..." If we are OK with that, then we can kill it. If not, then it might be nice to have an "as shipped from Project R3D" folder somewhere. |
@JohnOCFII neither option I outlined really advocated killing it - more gave us two options on how to keep it. I think how we approach this needs be driven by whether it's going to be maintained. The proposed change puts is in a weird spot where we publish the "legacy config" seemingly as an equal to the "community config." On one hand that's sensible because that's what the kits reference, but nobody who contributes here uses or cares for that config. We aren't supporting it or caring for it, so it's in no way an equal to our "community config" efforts. I don't want people to see the master branch of this repo and thing these are both well-maintained and supported alternatives if that's not true. I'm simply advocating that we clarify what level of support we plan to have for the "legacy config" (whatever we call it) and then basing how we structure the repo on that. In a perfect world, @Project-R3D would get involved here and we could converge on one config for everything going out. That would simplify community support greatly, and their kits would be better off for it. |
The plan is to standardize it, we have been waiting on the new stepper
motors to arrive which will mix things up. Sadly this isn't a perfect
world, it takes 6-8 weeks to get a large order of stepper motors. Until
these arrive there is no point of pushing standardization.
…On Fri, May 24, 2019, 3:58 PM Joe Francis ***@***.***> wrote:
@JohnOCFII <https://github.com/JohnOCFII> neither option I outlined
really advocated killing it - more gave us two options on how to keep it. I
think how we approach this needs be driven by whether it's going to be
maintained.
The proposed change puts is in a weird spot where we publish the "legacy
config" seemingly as an equal to the "community config." On one hand that's
sensible because that's what the kits reference, but nobody who contributes
here uses or cares for that config. We aren't supporting it or caring for
it, so it's in no way an equal to our "community config" efforts. I don't
want people to see the master branch of this repo and thing these are both
well-maintained and supported alternatives if that's not true.
I'm simply advocating that we clarify what level of support we plan to
have for the "legacy config" (whatever we call it) and then basing how we
structure the repo on that.
In a perfect world, @Project-R3D <https://github.com/Project-R3D> would
get involved here and we could converge on one config for everything going
out. That would simplify community support greatly, and their kits would be
better off for it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#73?email_source=notifications&email_token=AHBWNPHEF5PKBF2NOKCFA43PXBJHLA5CNFSM4HPN7VS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWGRRJI#issuecomment-495786149>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHBWNPCYMOM7JJLIBHBXKETPXBJHLANCNFSM4HPN7VSQ>
.
|
Standardize on what exactly @Project-R3D - the community config we've developed or something else? |
The plan is to have the kit work as seamlessly as possible with the
community config.
…On Fri, May 24, 2019, 4:04 PM Joe Francis ***@***.***> wrote:
The plan is to standardize it, we have been waiting on the new stepper
motors to arrive which will mix things up. Sadly this isn't a perfect
world, it takes 6-8 weeks to get a large order of stepper motors. Until
these arrive there is no point of pushing standardization.
Standardize on what exactly @Project-R3D <https://github.com/Project-R3D>
- the community config we've developed or something else?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#73?email_source=notifications&email_token=AHBWNPCCNGO6HKFIJZ6CL7DPXBJ7RA5CNFSM4HPN7VS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWGR5WI#issuecomment-495787737>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHBWNPBICU4DVP5IFFIQSB3PXBJ7RANCNFSM4HPN7VSQ>
.
|
I'd like to change the folder name from "unmaintained" to "original" as I believe the original configs are useful for troubleshooting.
I have a github docs branch change ready to change the links if this is accepted.