Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump react-native-community/blur to fix a crash for some Android users #5107

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

jinchung
Copy link
Member

Fixes APP-852

Additional context in ticket

@linear
Copy link

linear bot commented Oct 10, 2023

APP-852 Android Crashlytics crash: react-native-community/blur Software rendering doesn't support drawRenderNode

https://console.firebase.google.com/u/0/project/rainbow-me/crashlytics/app/android:me.rainbow/issues/472f3681c205fea2c4a575deaa0dea29?time=last-seven-days&types=crash&sessionEventKey=6521AB3A027A0001108FFB249B812811_1865739559272587081

Fatal Exception: java.lang.IllegalArgumentException
Software rendering doesn't support drawRenderNode

This seems to be a crash happening for Android users likely with devices that don't support hardware acceleration

Here is the issue thread with the fix in the latest blur package (4.3.2)

Kureev/react-native-blur#489 (comment)

@socket-security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@react-native-community/blur 4.3.0...4.3.2 None +0/-0 109 kB titozzz

@socket-security
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Potential typo squat schedule 0.5.0

Next steps

What is a potential typo squat?

Package name is similar to other popular packages and may not be the package you want.

Use care when consuming similarly named packages and ensure that you did not intend to consume a different package. Malicious packages often publish using similar names as existing popular packages.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@jinchung jinchung merged commit dab593b into develop Oct 10, 2023
3 of 5 checks passed
@jinchung jinchung deleted the @jin/android-blur-crash branch October 10, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants