-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[e2e] Add Malicious Dapp interaction test #5764
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…licious-dapp-warning-e2e * 'develop' of github.com:rainbow-me/rainbow: Swaps: package upgrades, fix SwapBackground and AnimatedSwapSpinner (#5775) Swaps: fix safe math negative number support, add comparison functions (#5776) Reanimated v3.11.0 (#5683) Gas (#5757) add degen chain to network selector (#5766) prefer local chain image over custom (#5772) add safe math fns (#5765) filter out assets from curated assets with no icon_url (#5768) fix isQuoteStale lag (#5769) fix icon sizing (#5771) Preliminary work: Update formatter functions to take in object params (#5760) APP-1500 (#5763) chore: i18n updates (#5762)
BrodyHughes
changed the title
[WIP] Brody/malicious dapp warning e2e
[e2e] Add Malicious Dapp interaction test
May 29, 2024
walmat
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. nits
Co-authored-by: Matthew Wall <[email protected]>
benisgold
reviewed
Jun 4, 2024
brunobar79
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
BrodyHughes
added a commit
that referenced
this pull request
Jun 11, 2024
…ap-v2-e2e * 'develop' of github.com:rainbow-me/rainbow: Fix weird issues with rounding (#5822) Fix provider recursion bug, provider function types (#5829) bump braces (#5831) Add entry point for other networks (#5824) remove info icon on max transaction fee row as we don't have that in spec (#5827) [e2e] Add Malicious Dapp interaction test (#5764) reorg ens related calls (#5828) Performance: limit Sentry tracking, fix NFT hooks (#5819) fix wrong chainname (#5823) Disable flashbots toggle on appropriate chains (#5812) add type to SearchAsset type and add into type possibilities (#5820) fix fasterimage border radius android (#5816) more Safemath fixes (#5818)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1461
What changed (plus any additional context for devs)
Screen recordings / screenshots
Screen.Recording.2024-05-29.at.3.13.10.PM.mov
What to test