swap button states #5785
Merged
swap button states #5785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add more fns * accept string or number * update errors
* . * oop * oop * okay ty ben * change background opacity to 1 * . * oop * .
* perf * ✨ * useWhyDidYouUpdate * EstimatedSwapGasFee * keepPreviousData * AnimatedText * isSameAddress
* fix * android fix
walmat
reviewed
May 29, 2024
src/__swaps__/screens/Swap/components/GestureHandlerV1Button.tsx
Outdated
Show resolved
Hide resolved
src/__swaps__/screens/Swap/components/GestureHandlerV1Button.tsx
Outdated
Show resolved
Hide resolved
greg-schrammel
commented
Jun 5, 2024
greg-schrammel
commented
Jun 5, 2024
walmat
reviewed
Jun 11, 2024
walmat
reviewed
Jun 11, 2024
walmat
reviewed
Jun 11, 2024
greg-schrammel
commented
Jun 12, 2024
Comment on lines
+35
to
+44
| export const useSyncedSwapQuoteStore = create<InternalSyncedSwapState>(() => ({ | ||
| assetToBuy: undefined, | ||
| assetToSell: undefined, | ||
| chainId: undefined, | ||
| quote: null, | ||
| })); | ||
| const setInternalSyncedSwapStore = debounce((state: InternalSyncedSwapState) => useSyncedSwapQuoteStore.setState(state), 100, { | ||
| leading: false, | ||
| trailing: true, | ||
| }); |
There was a problem hiding this comment.
went with a external store to prevent unnecessary rerenders
jinchung
reviewed
Jun 12, 2024
walmat
reviewed
Jun 12, 2024
walmat
approved these changes
Jun 13, 2024
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-06-13.at.16.05.37.mp4I'm seeing a consistent flashing when going back and forth between max and less than max for the network's native token:
|
walmat
approved these changes
Jun 14, 2024
jinchung
added a commit
that referenced
this pull request
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1486
What changed (plus any additional context for devs)
Screen recordings / screenshots
Screen.Recording.2024-06-05.at.16.50.04.mov
What to test