Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e] Brody/swap v2 e2e #5814

Closed
wants to merge 13 commits into from
Closed

[e2e] Brody/swap v2 e2e #5814

wants to merge 13 commits into from

Conversation

BrodyHughes
Copy link
Member

@BrodyHughes BrodyHughes commented Jun 4, 2024

Fixes APP-1546

What changed (plus any additional context for devs)

  • Implemented Swaps v2 basic swap flow
  • the scope was becoming increasingly large, so wanted to merge before it got worse
  • Simplified our e2e setup in anticipation for mocking (???)
  • @walmat refactored some user asset things to make sure Hardhat assets show up
  • removed old, unused test files to clean up e2e codebase
  • added testID where needed
  • flipped on config/experimental flags for tests when needed

What to test

  • Does it pass?

@BrodyHughes BrodyHughes marked this pull request as ready for review June 11, 2024 17:55
Copy link

socket-security bot commented Jun 11, 2024

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@rainbow-me rainbow-me deleted a comment from socket-security bot Jun 12, 2024
Copy link

linear bot commented Jun 12, 2024

@BrodyHughes BrodyHughes changed the title [WIP] [e2e] Brody/swap v2 e2e [e2e] Brody/swap v2 e2e Jun 12, 2024
@brunobar79
Copy link
Member

@BrodyHughes do u mind rebasing? commit history is crazy 😅

author BrodyHughes <[email protected]> 1717436426 -0500
committer BrodyHughes <[email protected]> 1718422215 -0500

.

.

.

lots of fixes to hardhat assets

fix user assets and list out more tests

start mocking

add quote response mocks and fix testID tap

remove global fetch

okie

remove custom type and consume directly QuoteParams type

finish basic flow

.

.

.

comments

.

.

clean up

oop

clean

rm unused package bumps

prettier -_-

.

.

.

:/

.

.

.

.

.

.
BrodyHughes and others added 11 commits June 14, 2024 23:39
…ap-v2-e2e

* 'develop' of github.com:rainbow-me/rainbow:
  Swaps: fix initial input native currency value, light mode coin icon placeholder (#5856)
…ap-v2-e2e

* 'develop' of github.com:rainbow-me/rainbow:
  add back close button to swap input select asset (#5859)
  Default to native output when swapping erc-20s (#5857)
  fix swaps v1 (#5858)
…ap-v2-e2e

* 'develop' of github.com:rainbow-me/rainbow:
  Swaps: subtract gas fee buffer from native token balances (#5845)
  Fix small balance threshold not being reactive (#5865)
  Revert "fix for small balance threshold not being updated (#5861)" (#5864)
  fix for small balance threshold not being updated (#5861)
@BrodyHughes BrodyHughes closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants