Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint on pre-commit #5836

Merged
merged 16 commits into from
Jun 14, 2024
Merged

Lint on pre-commit #5836

merged 16 commits into from
Jun 14, 2024

Conversation

BrodyHughes
Copy link
Member

@BrodyHughes BrodyHughes commented Jun 11, 2024 •
edited
Loading

What changed

  • this runs this on pre-commit now:
  "lint-staged": {
    "*.{js,jsx,ts,tsx}": [
      "prettier --check",
      "yarn tsc --skipLibCheck --noEmit --allowJs",
      "eslint --fix"
    ]
  },
  • this makes commiting changes take 10-20 seconds, but the tradeoff is you won't see a PR failing due to linting errors now
  • just gotta decide if this tradeoff is worth or not

@BrodyHughes BrodyHughes changed the title Brody/lint on pre commit Lint on pre-commit Jun 13, 2024
@BrodyHughes BrodyHughes marked this pull request as ready for review June 13, 2024 18:21
walmat
walmat reviewed Jun 13, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
walmat
walmat reviewed Jun 13, 2024
View reviewed changes
package.json Show resolved Hide resolved
BrodyHughes and others added 7 commits June 13, 2024 14:17
@BrodyHughes
.
a71cd70
@BrodyHughes
Merge branch 'brody/lint-on-pre-commit' of github.com:rainbow-me/rain…
3b1fd6e 
…bow into brody/lint-on-pre-commit

* 'brody/lint-on-pre-commit' of github.com:rainbow-me/rainbow:
  Math related fixes (#5837)
  Hide Flashbots outside of mainnet (#5842)
  fix getProviderForNetwork type (#5843)
  Fix isSwapping not being reset (#5840)
  Swaps: fix crashes, logic and UI fixes (#5839)
  default to fast suggestion if custom is not set (#5841)
  guard each entry point into swaps to prevent readonly wallets from accessing it (#5835)
  Swaps: token list and search improvements (#5834)
  Add analytics (#5805)
@walmat
Merge branch 'develop' into brody/lint-on-pre-commit
3ffd566
@BrodyHughes
.
afe49fc
@BrodyHughes
Merge branch 'brody/lint-on-pre-commit' of github.com:rainbow-me/rain…
0d9ff26 
…bow into brody/lint-on-pre-commit

* 'brody/lint-on-pre-commit' of github.com:rainbow-me/rainbow:
  <UnmountOnAnimatedReaction /> (#5810)
@BrodyHughes
.
3a88455
@walmat
Merge branch 'develop' into brody/lint-on-pre-commit
047a4dc
@jinchung jinchung merged commit d56ed46 into develop Jun 14, 2024
6 checks passed
@jinchung jinchung deleted the brody/lint-on-pre-commit branch June 14, 2024 17:31
walmat added a commit that referenced this pull request Jun 14, 2024
@walmat
Revert "Lint on pre-commit (#5836)"
fea8f65 
This reverts commit d56ed46.
@walmat walmat restored the brody/lint-on-pre-commit branch June 14, 2024 18:33
brunobar79 pushed a commit that referenced this pull request Jun 14, 2024
@walmat
Revert "Lint on pre-commit (#5836)" (#5849)
e7a70ed 
This reverts commit d56ed46.
BrodyHughes added a commit that referenced this pull request Jun 14, 2024
@BrodyHughes
Merge branch 'brody/swap-v2-e2e' of github.com:rainbow-me/rainbow int…
f875218 
…o brody/swap-v2-e2e

* 'brody/swap-v2-e2e' of github.com:rainbow-me/rainbow:
  Revert "Lint on pre-commit (#5836)" (#5849)
  Lint on pre-commit (#5836)
  Swaps: fix handling of native currency formatting/presentation (#5826)
  Android crash fix from BlurView (#5844)
  Fix favorites nuances (#5846)
  fix quoted decimals issue (#5847)
greg-schrammel added a commit that referenced this pull request Jun 14, 2024
@greg-schrammel @walmat
@brunobar79 @BrodyHughes @benisgold
swap button states (#5785)
fc0ff05 
* wip

* fix gesture button states

* Safemath pt 2 (#5778)

* add more fns

* accept string or number

* update errors

* fix dynamic island overlap on recieve modal (#5672)

* .

* oop

* oop

* okay ty ben

* change background opacity to 1

* .

* oop

* .

* Gas optimizations (#5779)

* perf

* ✨

* useWhyDidYouUpdate

* EstimatedSwapGasFee

* keepPreviousData

* AnimatedText

* isSameAddress

* fix other networks section (#5784)

* Swaps: fix favorite button press (#5782)

* fix

* android fix

* todo

* remove console logs

* Insufficient Funds

* remove todo

* move cache getter closer to fetcher implentation

* fix

* :)

* 🍕

* or equal 🤌

* remove unused isSameAddress util

* just reordering declarations

* error i18n

* useGasSharedValues

* remove estimating

* fix label flickering

* fix review panel not prompting

* Revert "Lint on pre-commit (#5836)"

This reverts commit d56ed46.

* fix a bunch of shit

---------

Co-authored-by: Matthew Wall <[email protected]>
Co-authored-by: Bruno Barbieri <[email protected]>
Co-authored-by: brdy <[email protected]>
Co-authored-by: Ben Goldberg <[email protected]>
greg-schrammel added a commit that referenced this pull request Jun 15, 2024
@greg-schrammel @walmat
swap paste button in output field (#5804)
3de6fe7 
* paste

* remove console.log

* better

* colors

* ok

* review

* comment

* Revert "Lint on pre-commit (#5836)"

This reverts commit d56ed46.

* fix dupes

---------

Co-authored-by: Matthew Wall <[email protected]>
walmat added a commit that referenced this pull request Jun 17, 2024
@walmat
Fix BSC bridges (#5855)
0e8bf36 
* Revert "Lint on pre-commit (#5836)"

This reverts commit d56ed46.

* fix bsc and some other nuances
brunobar79 added a commit that referenced this pull request Jun 21, 2024
@walmat @greg-schrammel
@brunobar79 @BrodyHughes @benisgold @jinchung
Review button states (#5854)
56abcd6 
* wip

* fix gesture button states

* Safemath pt 2 (#5778)

* add more fns

* accept string or number

* update errors

* fix dynamic island overlap on recieve modal (#5672)

* .

* oop

* oop

* okay ty ben

* change background opacity to 1

* .

* oop

* .

* Gas optimizations (#5779)

* perf

* ✨

* useWhyDidYouUpdate

* EstimatedSwapGasFee

* keepPreviousData

* AnimatedText

* isSameAddress

* fix other networks section (#5784)

* Swaps: fix favorite button press (#5782)

* fix

* android fix

* todo

* remove console logs

* Insufficient Funds

* remove todo

* move cache getter closer to fetcher implentation

* fix

* :)

* 🍕

* or equal 🤌

* remove unused isSameAddress util

* just reordering declarations

* error i18n

* useGasSharedValues

* remove estimating

* fix label flickering

* fix review panel not prompting

* Revert "Lint on pre-commit (#5836)"

This reverts commit d56ed46.

* fix a bunch of shit

* fix?

* opacity

* on review panel we should show fetching status and quote errors too

* remove error

* useUserNativeNetworkAsset

* less or equal

* Fixes for review button states (#5873)

* Fixes APP-1601: adds missing useThreshold for gas fee showing $0.00

* Tweak confirm button prop labels logic and ordering

* Prep work: remove reliance of asset balance display in valueBasedDecimalFormatter

* niceIncrementerFormatter returns asset balance if max swap

* Update formattedInputValue

Instead of using the niceIncrementFormatter for formatting slider-based
values:
for max: use the valueBasedDecimalFormatter on the input value which has
already been set to maxSwappableAmount
for everything else: add commas to the input value as it has already been
formatted using the niceIncrementFormatter

* Fixup: missed spot for previous hasEnoughFundsForGas revert

* fix formatting

---------

Co-authored-by: gregs <[email protected]>
Co-authored-by: Bruno Barbieri <[email protected]>
Co-authored-by: brdy <[email protected]>
Co-authored-by: Ben Goldberg <[email protected]>
Co-authored-by: Jin <[email protected]>
Co-authored-by: Bruno Barbieri <[email protected]>
jinchung added a commit that referenced this pull request Jun 22, 2024
@benisgold @greg-schrammel
@walmat @brunobar79 @BrodyHughes @jinchung
Swaps: Gas fee range to use for native asset maxSwappableAmount buffer (
a5087f2 
#5881)

* wip

* fix gesture button states

* Safemath pt 2 (#5778)

* add more fns

* accept string or number

* update errors

* fix dynamic island overlap on recieve modal (#5672)

* .

* oop

* oop

* okay ty ben

* change background opacity to 1

* .

* oop

* .

* Gas optimizations (#5779)

* perf

* ✨

* useWhyDidYouUpdate

* EstimatedSwapGasFee

* keepPreviousData

* AnimatedText

* isSameAddress

* fix other networks section (#5784)

* Swaps: fix favorite button press (#5782)

* fix

* android fix

* todo

* remove console logs

* Insufficient Funds

* remove todo

* move cache getter closer to fetcher implentation

* fix

* :)

* 🍕

* or equal 🤌

* remove unused isSameAddress util

* just reordering declarations

* error i18n

* useGasSharedValues

* remove estimating

* fix label flickering

* fix review panel not prompting

* Revert "Lint on pre-commit (#5836)"

This reverts commit d56ed46.

* fix a bunch of shit

* fix?

* opacity

* on review panel we should show fetching status and quote errors too

* remove error

* useUserNativeNetworkAsset

* less or equal

* gas fee range

* fixes

* Fixes for review button states (#5873)

* Fixes APP-1601: adds missing useThreshold for gas fee showing $0.00

* Tweak confirm button prop labels logic and ordering

* Prep work: remove reliance of asset balance display in valueBasedDecimalFormatter

* niceIncrementerFormatter returns asset balance if max swap

* Update formattedInputValue

Instead of using the niceIncrementFormatter for formatting slider-based
values:
for max: use the valueBasedDecimalFormatter on the input value which has
already been set to maxSwappableAmount
for everything else: add commas to the input value as it has already been
formatted using the niceIncrementFormatter

* merge

* weird issues

* fixes

* fix out of sync issue

* update input amount + quote when maxSwappableAmount changes

* fix input formatting logic

* fix wei conversion

---------

Co-authored-by: gregs <[email protected]>
Co-authored-by: Matthew Wall <[email protected]>
Co-authored-by: Bruno Barbieri <[email protected]>
Co-authored-by: brdy <[email protected]>
Co-authored-by: Jin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walmat walmat walmat approved these changes

@benisgold benisgold Awaiting requested review from benisgold

@jinchung jinchung Awaiting requested review from jinchung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrodyHughes @walmat @jinchung